Re: [COMMITTERS] pgsql: Make S_IRGRP etc available in mingw builds as well as MSVC.

Make S_IRGRP etc available in mingw builds as well as MSVC.

(Hm, I wonder whether BCC defines them either...)

Also label dangling endifs a bit better in this area.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=5132ad8bdf8e85ea0054217ef7ee38c51ace4824

Modified Files
--------------
src/include/port/win32.h | 30 +++++++++++++++++-------------
1 files changed, 17 insertions(+), 13 deletions(-)

On 12/12/2010 01:43 PM, Tom Lane wrote:
> Make S_IRGRP etc available in mingw builds as well as MSVC.
>
> (Hm, I wonder whether BCC defines them either...)
>
>

Is anyone building the client stuff with BCC any more? I don't recall
having heard of anyone doing so for quite some years.

cheers

andrew

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 12/12/2010 01:43 PM, Tom Lane wrote:
>> (Hm, I wonder whether BCC defines them either...)

> Is anyone building the client stuff with BCC any more? I don't recall
> having heard of anyone doing so for quite some years.

It's a fair question. We could clean up some of these messy ifdefs
if we dropped support for that combination. I assume that an MSVC-built
libpq.dll would still work for Borland users, no?

regards, tom lane

On Sun, Dec 12, 2010 at 19:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 12/12/2010 01:43 PM, Tom Lane wrote:
>>> (Hm, I wonder whether BCC defines them either...)
>
>> Is anyone building the client stuff with BCC any more? I don't recall
>> having heard of anyone doing so for quite some years.
>
> It's a fair question.  We could clean up some of these messy ifdefs
> if we dropped support for that combination.  I assume that an MSVC-built
> libpq.dll would still work for Borland users, no?

The dynamic one, yes. Static linked one, no.

IIRC I suggest desupporting it every now and then and get voted down
;) And quite often we have someone showing up around the x.y.2 release
to clean it up so it works again...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sun, Dec 12, 2010 at 19:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It's a fair question. We could clean up some of these messy ifdefs
>> if we dropped support for that combination. I assume that an MSVC-built
>> libpq.dll would still work for Borland users, no?

> The dynamic one, yes. Static linked one, no.

> IIRC I suggest desupporting it every now and then and get voted down
> ;) And quite often we have someone showing up around the x.y.2 release
> to clean it up so it works again...

Yeah, a look in the commit logs shows that happening about once a year.
It'd sure be nice if we had a less haphazard process for it though.

regards, tom lane