Re: [NOVICE] connectby() minor bug in errormessage

Lists: pgsql-novicepgsql-patches
From: Nabil Sayegh <postgresql(at)e-trolley(dot)de>
To: pgsql-novice <pgsql-novice(at)postgresql(dot)org>
Subject: connectby() minor bug in errormessage
Date: 2003-06-25 00:56:41
Message-ID: 1056502601.3449.51.camel@billy
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice pgsql-patches

validateConnectbyTupleDesc

When the fourth column (tupdesc->attrs[3]) fails the type check, the
errormessage should be "fourth column must be..." and not "third column
must be ..."

line 1372
http://www.joeconway.com/tablefunc.tar.gz

bye
--
e-Trolley Sayegh & John, Nabil Sayegh
Tel.: 0700 etrolley /// 0700 38765539
Fax.: +49 69 8299381-8
PGP : http://www.e-trolley.de

From: Joe Conway <mail(at)joeconway(dot)com>
To: Nabil Sayegh <postgresql(at)e-trolley(dot)de>
Cc: pgsql-novice <pgsql-novice(at)postgresql(dot)org>
Subject: Re: connectby() minor bug in errormessage
Date: 2003-06-25 02:37:44
Message-ID: 3EF90AF8.9090706@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice pgsql-patches

Nabil Sayegh wrote:
> validateConnectbyTupleDesc
>
> When the fourth column (tupdesc->attrs[3]) fails the type check, the
> errormessage should be "fourth column must be..." and not "third column
> must be ..."
>
> line 1372
> http://www.joeconway.com/tablefunc.tar.gz
>

Yup, looks like a cut-n-pasteo.

Thanks,

Joe

From: Joe Conway <mail(at)joeconway(dot)com>
To: Nabil Sayegh <postgresql(at)e-trolley(dot)de>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [NOVICE] connectby() minor bug in errormessage
Date: 2003-06-25 02:57:00
Message-ID: 3EF90F7C.9030508@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice pgsql-patches

Nabil Sayegh wrote:
> validateConnectbyTupleDesc
>
> When the fourth column (tupdesc->attrs[3]) fails the type check, the
> errormessage should be "fourth column must be..." and not "third column
> must be ..."
>
> line 1372
> http://www.joeconway.com/tablefunc.tar.gz

Attached is a patch for the issue reported above by Nabil. Please apply.

Thanks,

Joe

Attachment Content-Type Size
connectby-msg-fix.patch text/plain 1.0 KB
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Nabil Sayegh <postgresql(at)e-trolley(dot)de>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [NOVICE] connectby() minor bug in errormessage
Date: 2003-06-25 18:14:38
Message-ID: 7582.1056564878@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-novice pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> Attached is a patch for the issue reported above by Nabil. Please apply.

Applied (with correct spelling ...)

regards, tom lane