| Lists: | pgsql-docs |
|---|
| From: | "Erik Rijkers" <er(at)xs4all(dot)nl> |
|---|---|
| To: | pgsql-docs(at)postgresql(dot)org |
| Subject: | release-9.0.sgml changes |
| Date: | 2010-07-09 21:24:13 |
| Message-ID: | 6ff013c74f52c1874e0973f8dbc16865.squirrel@webmail.xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
Some readability improvements (I hope),
and some typos
Erik Rijkers
| Attachment | Content-Type | Size |
|---|---|---|
| release-9.0.sgml.diff | application/octet-stream | 6.0 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | pgsql-docs(at)postgresql(dot)org |
| Subject: | Re: release-9.0.sgml changes |
| Date: | 2010-07-10 00:27:23 |
| Message-ID: | AANLkTinRWIEqR-9-qLTa1B8-t20qa2hmpunUV8K__6lF@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> Some readability improvements (I hope),
> and some typos
You seem to have removed the mention of PL/pgsql being installed by
default, which doesn't seem right.
I also notice that adjacent to one of your changes we have
"privileges" spelled as "priveleges" - this is not a fault in your
patch, but we should probably fix it.
I don't think I agree with these:
- Fix <command>psql --file -</> to properly honor <link
+ Fix <command>psql --file -</> (i.e. STDIN) to properly honor <link
- Improve <filename>/contrib/dblink</>s handling of dropped columns
+ Improve <filename>/contrib/dblink</>'s handling of dropped columns
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From: | "Erik Rijkers" <er(at)xs4all(dot)nl> |
|---|---|
| To: | "Robert Haas" <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-docs(at)postgresql(dot)org |
| Subject: | Re: release-9.0.sgml changes |
| Date: | 2010-07-10 08:09:22 |
| Message-ID: | 3c9cbd88d85ac036440f764d4dc278db.squirrel@webmail.xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
On Sat, July 10, 2010 02:27, Robert Haas wrote:
> On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> Some readability improvements (I hope),
>> and some typos
>
> You seem to have removed the mention of PL/pgsql being installed by
> default, which doesn't seem right.
>
I just thought it silly to parade such a minimal change in an overview of Major Enhancement Areas.
But obviously none of what I sent matters much. Maybe you (or someone) can just pick out & apply
the obvious typos?
Erik Rijkers
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-docs(at)postgresql(dot)org |
| Subject: | Re: release-9.0.sgml changes |
| Date: | 2010-07-12 18:29:14 |
| Message-ID: | 201007121829.o6CITED15704@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
Robert Haas wrote:
> On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> > Some readability improvements (I hope),
> > and some typos
>
> You seem to have removed the mention of PL/pgsql being installed by
> default, which doesn't seem right.
>
> I also notice that adjacent to one of your changes we have
> "privileges" spelled as "priveleges" - this is not a fault in your
> patch, but we should probably fix it.
Fixed.
> I don't think I agree with these:
>
> - Fix <command>psql --file -</> to properly honor <link
> + Fix <command>psql --file -</> (i.e. STDIN) to properly honor <link
> - Improve <filename>/contrib/dblink</>s handling of dropped columns
> + Improve <filename>/contrib/dblink</>'s handling of dropped columns
Agreed.
Remainder of patch applied. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 8.6 KB |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-docs(at)postgresql(dot)org |
| Subject: | Re: release-9.0.sgml changes |
| Date: | 2010-07-12 18:31:00 |
| Message-ID: | 201007121831.o6CIV0a16136@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
Erik Rijkers wrote:
> On Sat, July 10, 2010 02:27, Robert Haas wrote:
> > On Fri, Jul 9, 2010 at 5:24 PM, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> >> Some readability improvements (I hope),
> >> and some typos
> >
> > You seem to have removed the mention of PL/pgsql being installed by
> > default, which doesn't seem right.
> >
>
> I just thought it silly to parade such a minimal change in an overview of Major Enhancement Areas.
>
> But obviously none of what I sent matters much. Maybe you (or someone) can just pick out & apply
> the obvious typos?
Done. I kept the pl/pgsql default install mention in the release notes.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +