Changes for AIX buildfarm

Lists: pgsql-patches
From: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: Changes for AIX buildfarm
Date: 2005-07-18 16:21:44
Message-ID: 6E0907A94904D94B99D7F387E08C4F5730E8E5@FALCON.INSIGHT
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Need to have these patches applied to get AIX 5.2 to build as a member
of the buildfarm.

The Makefile.shlib patch allows all the contrib modules to build (this
seems to be the same problem that cygwin is facing). AIX needs -lm (to
pick up math routines for atleast cube module). I am not sure why the
other platforms build without this.

There are C++ style comments in contrib/pgcrypto which is giving cc
problems.

Thanks,
-rocco

Attachment Content-Type Size
Makefile.shlib.patch application/octet-stream 746 bytes
pg_crypto.patch application/octet-stream 1.5 KB
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-18 16:32:21
Message-ID: 12807.1121704341@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

"Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
> Need to have these patches applied to get AIX 5.2 to build as a member
> of the buildfarm.

Er, which buildfarm report is prompting this?

> There are C++ style comments in contrib/pgcrypto which is giving cc
> problems.

Definitely contrary to project policy, will fix.

regards, tom lane

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rocco Altier <RoccoA(at)Routescape(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-18 16:42:06
Message-ID: 42DBDBDE.4000700@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Tom Lane wrote:

>"Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
>
>
>>Need to have these patches applied to get AIX 5.2 to build as a member
>>of the buildfarm.
>>
>>
>
>Er, which buildfarm report is prompting this?
>
>
>

Rocco is probably doing what I normally ask, which is to get builds
working before starting to upload results to the buildfarm server (a
request which is more honored in the breach than the observance).

cheers

andrew

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Rocco Altier <RoccoA(at)Routescape(dot)com>, "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-18 16:46:42
Message-ID: 12921.1121705202@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> Er, which buildfarm report is prompting this?

> Rocco is probably doing what I normally ask, which is to get builds
> working before starting to upload results to the buildfarm server (a
> request which is more honored in the breach than the observance).

Fair enough. But I'm concerned about the proposed patch because it
seems to revert a deliberate change made some time ago:

http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib#rev1.65
http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php

so I think we need more eyeballs on the problem before deciding this is
a good fix.

regards, tom lane

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rocco Altier <RoccoA(at)Routescape(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-18 16:57:07
Message-ID: 20050718165707.GA1837@l-t.ee
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

On Mon, Jul 18, 2005 at 12:32:21PM -0400, Tom Lane wrote:
> "Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
> > There are C++ style comments in contrib/pgcrypto which is giving cc
> > problems.
>
> Definitely contrary to project policy, will fix.

Don't, they are fixed in "small cleanups" patch that I sent.

--
marko

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Marko Kreen <marko(at)l-t(dot)ee>
Cc: Rocco Altier <RoccoA(at)Routescape(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-18 17:00:01
Message-ID: 13073.1121706001@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Marko Kreen <marko(at)l-t(dot)ee> writes:
> On Mon, Jul 18, 2005 at 12:32:21PM -0400, Tom Lane wrote:
>> Definitely contrary to project policy, will fix.

> Don't, they are fixed in "small cleanups" patch that I sent.

Too late, already committed ;-)

I will do something to clean up the mess...

regards, tom lane

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Rocco Altier <RoccoA(at)routescape(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at>
Subject: Re: Changes for AIX buildfarm
Date: 2005-07-20 18:12:01
Message-ID: 200507202012.03467.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Tom Lane wrote:
> Fair enough. But I'm concerned about the proposed patch because it
> seems to revert a deliberate change made some time ago:
>
> http://developer.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib#r
>ev1.65
> http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php
>
> so I think we need more eyeballs on the problem before deciding this
> is a good fix.

A potentially more correct solution would be to set SHLIB_LINK in the
makefiles of the affected modules only. Certainly we don't want to
link with all libraries all the time.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/