| Lists: | pgsql-hackers |
|---|
| From: | "Rocco Altier" <RoccoA(at)Routescape(dot)com> |
|---|---|
| To: | "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AIX buildfarm failure |
| Date: | 2006-07-13 20:29:11 |
| Message-ID: | 6E0907A94904D94B99D7F387E08C4F57013CFE38@FALCON.INSIGHT |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Now it dies on nodeSubplan.c...
I am guessing there will be others as well.
Perhaps a check to make sure postgres.h is first in the includes can be
added to the include checking scripts you have been updating?
Thanks,
-rocco
> -----Original Message-----
> From: Bruce Momjian [mailto:bruce(at)momjian(dot)us]
> Sent: Thursday, July 13, 2006 4:14 PM
> To: Tom Lane
> Cc: Rocco Altier; pgsql-hackers(at)postgresql(dot)org
> Subject: Re: [HACKERS] AIX buildfarm failure
>
>
>
> Fixed.
>
> --------------------------------------------------------------
> -------------
>
> Tom Lane wrote:
> > "Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
> > > If I move <math.h> down after "postgres.h" in nodeHash.c,
> the problem
> > > goes away.
> >
> > Bruce, you broke it. Have you forgotten the fundamental
> inclusion rule?
> > postgres.h (or postgres_fe.h, or c.h) first, then system
> headers, then
> > our own other headers.
> >
> > regards, tom lane
>
> --
> Bruce Momjian bruce(at)momjian(dot)us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Rocco Altier <RoccoA(at)Routescape(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: AIX buildfarm failure |
| Date: | 2006-07-13 20:46:17 |
| Message-ID: | 200607132046.k6DKkH312073@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Rocco Altier wrote:
> Now it dies on nodeSubplan.c...
>
> I am guessing there will be others as well.
I check them all the math.h mentions.
---------------------------------------------------------------------------
>
> Perhaps a check to make sure postgres.h is first in the includes can be
> added to the include checking scripts you have been updating?
>
> Thanks,
> -rocco
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:bruce(at)momjian(dot)us]
> > Sent: Thursday, July 13, 2006 4:14 PM
> > To: Tom Lane
> > Cc: Rocco Altier; pgsql-hackers(at)postgresql(dot)org
> > Subject: Re: [HACKERS] AIX buildfarm failure
> >
> >
> >
> > Fixed.
> >
> > --------------------------------------------------------------
> > -------------
> >
> > Tom Lane wrote:
> > > "Rocco Altier" <RoccoA(at)Routescape(dot)com> writes:
> > > > If I move <math.h> down after "postgres.h" in nodeHash.c,
> > the problem
> > > > goes away.
> > >
> > > Bruce, you broke it. Have you forgotten the fundamental
> > inclusion rule?
> > > postgres.h (or postgres_fe.h, or c.h) first, then system
> > headers, then
> > > our own other headers.
> > >
> > > regards, tom lane
> >
> > --
> > Bruce Momjian bruce(at)momjian(dot)us
> > EnterpriseDB http://www.enterprisedb.com
> >
> > + If your life is a hard drive, Christ can be your backup. +
> >
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +