Re: Updates for vcbuild

Lists: pgsql-hackerspgsql-patches
From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: <pgsql-patches(at)postgresql(dot)org>
Subject: Updates for vcbuild
Date: 2006-10-20 23:57:35
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FCAD@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

* Does version check on pgbison per previous discussion. Accepts 1.875,
or >2.0 except 2.1.
* Sets the stacksize from the makefile (as added to the standard
makefiles for mingw)
* Factor out a function read_file that reads a complete file, cuts down
the code a bit.
* Support for building contrib modules
* Builds zic.exe

//Magnus

Attachment Content-Type Size
vcbuild.diff application/octet-stream 15.6 KB

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Updates for vcbuild
Date: 2006-10-21 21:33:45
Message-ID: 28081.1161466425@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> [ various fixes ]

I'm confused: which of the files in src/tools/msvc need to have
Windows-style newlines, if any? GNU patch wants to strip the newlines
from your patches, so it'd be easiest from here if the answer is "none".

regards, tom lane


From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Updates for vcbuild
Date: 2006-10-22 09:18:32
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FCB4@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

> > [ various fixes ]
>
> I'm confused: which of the files in src/tools/msvc need to
> have Windows-style newlines, if any? GNU patch wants to
> strip the newlines from your patches, so it'd be easiest from
> here if the answer is "none".

Hmm. I think the answer should be "none", yes. Both .bat and .pl/.pm can
deal with unix style line breaks.

Looking around, I think my own cvs is getting confused over the mix, and
that's why it looks weird in the patch.

//Magnus


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: Updates for vcbuild
Date: 2006-10-22 17:18:07
Message-ID: 6352.1161537487@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Hmm. I think the answer should be "none", yes. Both .bat and .pl/.pm can
> deal with unix style line breaks.

OK, patch applied and all ^M's removed in src/tools/msvc/

regards, tom lane