| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | pg_strcasecmp in fe-connect.c |
| Date: | 2006-09-15 20:57:31 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FB99@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
This patch fixes a couple of cases where we use strcasecmp() instead of
pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.
//Magnu <<libpq_strcmp.diff>> s
| Attachment | Content-Type | Size |
|---|---|---|
| libpq_strcmp.diff | application/octet-stream | 1.5 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pg_strcasecmp in fe-connect.c |
| Date: | 2006-09-15 21:37:09 |
| Message-ID: | 6447.1158356229@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> This patch fixes a couple of cases where we use strcasecmp() instead of
> pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.
Applied. I found another instance in contrib/hstore, too. There are
also some occurrences in pgbench.c, but I'm unsure that we need be
paranoid about changing those.
regards, tom lane
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] pg_strcasecmp in fe-connect.c |
| Date: | 2006-09-16 11:37:42 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCEA0FBA7@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
> > This patch fixes a couple of cases where we use
> strcasecmp() instead
> > of
> > pg_strcasecmp() in fe_connect.c, coming from the LDAP client pathc.
>
> Applied. I found another instance in contrib/hstore, too.
Ah. msvc builds don't currently build /contrib, that's why I missed that
one.
> There are also some occurrences in pgbench.c, but I'm unsure
> that we need be paranoid about changing those.
If we ever want to be able to compile it on a platform that doesn't have
strcasecmp() (such as MSVC++), we would, no?
//Magnus
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] pg_strcasecmp in fe-connect.c |
| Date: | 2006-09-16 13:33:19 |
| Message-ID: | 14482.1158413599@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> There are also some occurrences in pgbench.c, but I'm unsure
>> that we need be paranoid about changing those.
> If we ever want to be able to compile it on a platform that doesn't have
> strcasecmp() (such as MSVC++), we would, no?
OK, replaced 'em all.
regards, tom lane