| Lists: | pgsql-patches |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Win32 version numbers not correct (again, but this one is easy) |
| Date: | 2004-12-30 21:31:06 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE47649E@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Seems to be a neverending story :-)
Version numbers don't update properly on postgres.exe when doing make
clean/make. It works for all other exes and dlls. I beleive this is just
a case of "make clean" not properly removing "win32ver.o". See attached
patch.
//Magnus
<<backend_clean.patch>>
| Attachment | Content-Type | Size |
|---|---|---|
| backend_clean.patch | application/octet-stream | 782 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Win32 version numbers not correct (again, but this one is easy) |
| Date: | 2004-12-30 21:49:24 |
| Message-ID: | 29178.1104443364@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Version numbers don't update properly on postgres.exe when doing make
> clean/make. It works for all other exes and dlls. I beleive this is just
> a case of "make clean" not properly removing "win32ver.o". See attached
> patch.
Hmm, is that the only place we missed it? Might be worth diffing a make
distclean'd tree against a virgin one.
regards, tom lane
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Win32 version numbers not correct (again, but this one |
| Date: | 2004-12-31 01:16:18 |
| Message-ID: | 200412310116.iBV1GIF22965@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Tom Lane wrote:
> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> > Version numbers don't update properly on postgres.exe when doing make
> > clean/make. It works for all other exes and dlls. I beleive this is just
> > a case of "make clean" not properly removing "win32ver.o". See attached
> > patch.
>
> Hmm, is that the only place we missed it? Might be worth diffing a make
> distclean'd tree against a virgin one.
I was under the impression we only wanted a new version number with a
configure run, however, I can see that "make clean" perhaps should do it
too.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Win32 version numbers not correct (again, but this one is easy) |
| Date: | 2004-12-31 03:57:26 |
| Message-ID: | 1372.1104465446@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Hmm, is that the only place we missed it? Might be worth diffing a make
>> distclean'd tree against a virgin one.
> I was under the impression we only wanted a new version number with a
> configure run, however, I can see that "make clean" perhaps should do it
> too.
No, it's not the source code file he's complaining about.
regards, tom lane
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Win32 version numbers not correct (again, but this one is easy) |
| Date: | 2004-12-31 19:12:49 |
| Message-ID: | 11394.1104520369@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Version numbers don't update properly on postgres.exe when doing make
> clean/make. It works for all other exes and dlls. I beleive this is just
> a case of "make clean" not properly removing "win32ver.o". See attached
> patch.
Applied, except I used $(WIN32RES) which seems more consistent with
what's done elsewhere.
regards, tom lane