| Lists: | pgsql-patches |
|---|
| From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
|---|---|
| To: | "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>, "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: pg_ctl service integration for WIN32 |
| Date: | 2004-06-20 15:26:56 |
| Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE34BCE3@algol.sollentuna.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
>
>Amended patch attached.
>Claudio
Hi!
Been testing this, and found a couple of small issues. Attached is a
patch that fixes these. (Note - Claudios patch is included in this one,
since it hasn't been applied yet..)
The issues:
1) When something goes bad, output went to stderr. No way to see that on
win32. Changed to put it to the eventlog when stderr is not a tty. This
also replaces the fprintf(stderr with write_stderr(, the same way my
backend patch does (updated version coming up soon).
2) Append ".exe" to the filename if that is not done automatically. It
wasn't done for me, but since other have had it running, it must work
sometimes... Without this, the service won't stard with an error stating
that there is no valid win32 executable availeble.
3) Prepend ".\" to the account name used to register the service, if no
domain is specified. Required for local domains, and makes it easier for
those not used to having to type .\ for local accounts..
Apart from those, looks good to me.
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| pg_ctl_service.patch | application/octet-stream | 24.4 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "Claudio Natoli" <claudio(dot)natoli(at)memetrics(dot)com>, "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pg_ctl service integration for WIN32 |
| Date: | 2004-06-24 18:38:56 |
| Message-ID: | 24277.1088102336@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> Amended patch attached.
>> Claudio
> Been testing this, and found a couple of small issues. Attached is a
> patch that fixes these. (Note - Claudios patch is included in this one,
> since it hasn't been applied yet..)
Applied, but where's the documentation update?
regards, tom lane