Lists: | pgsql-patches |
---|
From: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
---|---|
To: | "Neil Conway" <neilc(at)samurai(dot)com> |
Cc: | <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Cancel/Kill backend functions |
Date: | 2004-05-24 19:27:30 |
Message-ID: | 6BCB9D8A16AC4241919521715F4D8BCE34BAC3@algol.sollentuna.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
Okay, here is an updated patch. now uses IsBackendPid(), which is
closely modeled (read cut-and-pasted) from TransactionIdIsInProgress().
Since it's no longer a pgstat function, I moved it to "misc.c". Not 100%
that's the right place either, but it seemed like the best alternative.
//Magnus
>-----Original Message-----
>From: Neil Conway [mailto:neilc(at)samurai(dot)com]
>Sent: den 22 maj 2004 10:00
>To: Magnus Hagander
>Cc: pgsql-patches(at)postgresql(dot)org
>Subject: Re: [PATCHES] Cancel/Kill backend functions
>
>
>Magnus Hagander wrote:
>> Per previous discussions, here are two functions to send INT and TERM
>> signals to other backends.They permit only INT and TERM, and permits
>> sending only to postgresql backends (as registered in pgstat).
>
>Why does this depend on pgstat? ISTM it would be better to use the
>per-backend PGPROC information, which is stored in shared memory.
>Consider TransactionIdIsInProgress() for an example.
>
>-Neil
>
Attachment | Content-Type | Size |
---|---|---|
termbackend.patch | application/octet-stream | 3.3 KB |
From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <mha(at)sollentuna(dot)net> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Cancel/Kill backend functions |
Date: | 2004-05-26 18:50:28 |
Message-ID: | 200405261850.i4QIoS602216@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-patches |
Magnus, would you please resumbit this as a context diff?
---------------------------------------------------------------------------
Magnus Hagander wrote:
> Okay, here is an updated patch. now uses IsBackendPid(), which is
> closely modeled (read cut-and-pasted) from TransactionIdIsInProgress().
>
> Since it's no longer a pgstat function, I moved it to "misc.c". Not 100%
> that's the right place either, but it seemed like the best alternative.
>
> //Magnus
>
>
> >-----Original Message-----
> >From: Neil Conway [mailto:neilc(at)samurai(dot)com]
> >Sent: den 22 maj 2004 10:00
> >To: Magnus Hagander
> >Cc: pgsql-patches(at)postgresql(dot)org
> >Subject: Re: [PATCHES] Cancel/Kill backend functions
> >
> >
> >Magnus Hagander wrote:
> >> Per previous discussions, here are two functions to send INT and TERM
> >> signals to other backends.They permit only INT and TERM, and permits
> >> sending only to postgresql backends (as registered in pgstat).
> >
> >Why does this depend on pgstat? ISTM it would be better to use the
> >per-backend PGPROC information, which is stored in shared memory.
> >Consider TransactionIdIsInProgress() for an example.
> >
> >-Neil
> >
Content-Description: termbackend.patch
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073