| Lists: | pgsql-hackers |
|---|
| From: | shrish purohit <shrishpurohit(at)gmail(dot)com> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org>, kedar(dot)potdar(at)gmail(dot)com, Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> |
| Subject: | Patch for automated partitioning |
| Date: | 2009-10-30 12:25:32 |
| Message-ID: | 69b219810910300525q5bfbe7a7oa2408b464227271@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
Updated Kedar's patch sending on behalf of Kedar.
.tar.bz2 file contains files to be put at
./src/include/catalog/pg_partition.h
./src/backend/utils/partition
./src/test/regress/sql/partition.sql
There are not toomany modifications. It includes improvements for validating
multi-column partitioned tables.
propagation of constraints and indexes to child tables. addition of minvalue
and maxvalue. some bug fixes.
Thanks,
Shrish
Persistent Systems Ltd.
www.persistentsys.com
| Attachment | Content-Type | Size |
|---|---|---|
| automatic_partitioning.tar.bz2 | application/x-bzip2 | 54.3 KB |
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | shrish purohit <shrishpurohit(at)gmail(dot)com> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Hackers <pgsql-hackers(at)postgresql(dot)org>, kedar(dot)potdar(at)gmail(dot)com, Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> |
| Subject: | Re: Patch for automated partitioning |
| Date: | 2009-10-30 15:04:01 |
| Message-ID: | 1256915041.525.19.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, 2009-10-30 at 17:55 +0530, shrish purohit wrote:
> Hi,
>
> Updated Kedar's patch sending on behalf of Kedar.
>
> .tar.bz2 file contains files to be put at
> ./src/include/catalog/pg_partition.h
> ./src/backend/utils/partition
> ./src/test/regress/sql/partition.sql
>
> There are not toomany modifications. It includes improvements for
> validating multi-column partitioned tables.
> propagation of constraints and indexes to child tables. addition of
> minvalue and maxvalue. some bug fixes.
>
Thank you for your contribution, but please read
<http://petereisentraut.blogspot.com/2009/09/how-to-submit-patch-by-email.html> on how to submit a proper patch by email. A tarball of scattered files is not a convenient way of working, especially for a nontrivial feature like this.
| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | shrish purohit <shrishpurohit(at)gmail(dot)com> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org>, kedar(dot)potdar(at)gmail(dot)com, Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> |
| Subject: | Re: Patch for automated partitioning |
| Date: | 2009-11-02 07:44:05 |
| Message-ID: | 20091102164405.C6C3.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
shrish purohit <shrishpurohit(at)gmail(dot)com> wrote:
> Updated Kedar's patch sending on behalf of Kedar.
> There are not toomany modifications. It includes improvements for validating
> multi-column partitioned tables.
Thanks, but I'd like to keep the first patch as possible as simple.
I'll refer your work in the *next* step, especially partition
triggers and ALTER commands.
I glanced over your patch and find some codes that have room for improvement:
* Need to avoid RANGE and PARTITION to be reserved keywords.
* Non SQL-based operations are preferred if possible, so need to
reconsider pg_parse_query().
* Adding NOTICE message to completionTag is a very bad idea.
we don't need such feature because users can create trigger
on the overflow partition to send those messages.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center