Re: Fw: Case Insensitive Test

----- Original Message -----
From: "Manuel Sugawara" <masm(at)fciencias(dot)unam(dot)mx>
To: "Donald Fraser" <demolish(at)cwgsy(dot)net>
Cc: "[ADMIN]" <pgsql-admin(at)postgresql(dot)org>
Sent: Thursday, September 25, 2003 11:12 PM
Subject: Re: [ADMIN] Case Insensitive Test

> "Donald Fraser" <demolish(at)cwgsy(dot)net> writes:
>
> > The Case Insensitive Text data type for PostgreSQL is now part of
> > the GBorg projects.
> >
> > http://gborg.postgresql.org/project/citext/projdisplay.php
>
> Nice work, just two comments (1) the C++ comment style (//) is not
> portable for C programs and should be changed and (2) the standard way

Fair comment but since it has to be compiled against a valid PosgtreSQL
distribution, which all require GNU compilers, I don't see what the problem is.
All the C GNU compilers that I've ever used support C++ style comments which in
my opinion are much nicer to use.

> to distribute this kind of stuff is a tarball, zip is more from the
> windows world.

Ok its I added the tar.gz file to the distribution, which you'll note it twice
the size of the zip file. May be I don't know how to use tar properly but
that's why I used the zip format - it always seems to come out smaller by at
least a factor of 2.

Regards
Donald

"Donald Fraser" <demolish(at)cwgsy(dot)net> writes:
>> Nice work, just two comments (1) the C++ comment style (//) is not
>> portable for C programs and should be changed and (2) the standard way

> Fair comment but since it has to be compiled against a valid PosgtreSQL
> distribution, which all require GNU compilers,

We have several beta testers who keep us honest on exactly this point;
they use compilers that do not take //. Personally I wish gcc could
be configured not to have these little non-ANSI-isms ...

> Ok its I added the tar.gz file to the distribution, which you'll note
> it twice the size of the zip file.

Shouldn't be. Did you use "gzip -9"? For instance, I get these sorts
of numbers on a directory full of C source files:

$ ls -l z.*
-rw-r--r-- 1 tgl users 142048 Sep 25 20:40 z.tar.gz
-rw-r--r-- 1 tgl users 156389 Sep 25 20:41 z.zip

regards, tom lane

--On Thursday, September 25, 2003 20:43:36 -0400 Tom Lane
<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> "Donald Fraser" <demolish(at)cwgsy(dot)net> writes:
>>> Nice work, just two comments (1) the C++ comment style (//) is not
>>> portable for C programs and should be changed and (2) the standard way
>
>> Fair comment but since it has to be compiled against a valid PosgtreSQL
>> distribution, which all require GNU compilers,
>
> We have several beta testers who keep us honest on exactly this point;
> they use compilers that do not take //. Personally I wish gcc could
> be configured not to have these little non-ANSI-isms ...
Actually, I *THINK* C99 allows // comments, but that's neither here nor
there.
Any pre-C99 Non-GCC compiler won't allow it (I'm one of the aforementioned
beta
testers, I use the SCO cc (native) compiler on UnixWare)).

--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler(at)lerctr(dot)org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749

Larry Rosenman <ler(at)lerctr(dot)org> writes:
>> We have several beta testers who keep us honest on exactly this point;
>> they use compilers that do not take //. Personally I wish gcc could
>> be configured not to have these little non-ANSI-isms ...

> Actually, I *THINK* C99 allows // comments, but that's neither here nor
> there.

It does, but we still try to conform to ANSI C (C89 or whenever it was).

regards, tom lane

On Thu, 25 Sep 2003, Tom Lane wrote:

> "Donald Fraser" <demolish(at)cwgsy(dot)net> writes:
> >> Nice work, just two comments (1) the C++ comment style (//) is not
> >> portable for C programs and should be changed and (2) the standard way
>
> > Fair comment but since it has to be compiled against a valid PosgtreSQL
> > distribution, which all require GNU compilers,
>
> We have several beta testers who keep us honest on exactly this point;
> they use compilers that do not take //. Personally I wish gcc could
> be configured not to have these little non-ANSI-isms ...
>
> > Ok its I added the tar.gz file to the distribution, which you'll note
> > it twice the size of the zip file.
>
> Shouldn't be. Did you use "gzip -9"? For instance, I get these sorts
> of numbers on a directory full of C source files:
>
> $ ls -l z.*
> -rw-r--r-- 1 tgl users 142048 Sep 25 20:40 z.tar.gz
> -rw-r--r-- 1 tgl users 156389 Sep 25 20:41 z.zip

And, as always, bzip2 beats them both:

ls -l cit*
-rw------- 1 scott.ma scott.ma 6317 Sep 26 08:06 citext.tar.bz2
-rw------- 1 scott.ma scott.ma 7056 Sep 26 08:00 citext.tar.gz
-rw------- 1 scott.ma scott.ma 7334 Sep 26 08:01 citext.zip

(gzip run with -9 switch)