| Lists: | pgsql-hackers |
|---|
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Fast or immediate shutdown |
| Date: | 2009-12-15 17:19:12 |
| Message-ID: | 1260897552.1955.5121.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
running with log_checkpoints = on
pg_ctl -D foo -m fast stop
log says
LOG: received fast shutdown request
LOG: aborting any active transactions
LOG: shutting down
LOG: restartpoint starting: shutdown immediate
Some of us know that the "immediate" word refers to the restartpoint
request, though that word causes conceptual conflict with the shutdown
mode, which was fast, not immediate.
Think we need to change the wording of this
LOG: restartpoint starting: shutdown immediate
so it is clearer what we mean
--
Simon Riggs www.2ndQuadrant.com
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2009-12-15 18:14:55 |
| Message-ID: | 603c8f070912151014o723d19fbqfcc4b2e808550151@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Dec 15, 2009 at 12:19 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> running with log_checkpoints = on
>
> pg_ctl -D foo -m fast stop
>
> log says
>
> LOG: received fast shutdown request
> LOG: aborting any active transactions
> LOG: shutting down
> LOG: restartpoint starting: shutdown immediate
>
> Some of us know that the "immediate" word refers to the restartpoint
> request, though that word causes conceptual conflict with the shutdown
> mode, which was fast, not immediate.
>
> Think we need to change the wording of this
>
> LOG: restartpoint starting: shutdown immediate
>
> so it is clearer what we mean
We could insert the words "with flags" just before the colon, I suppose.
...Robert
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2009-12-16 15:04:32 |
| Message-ID: | 1260975872.13654.1.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> running with log_checkpoints = on
>
> pg_ctl -D foo -m fast stop
>
> log says
>
> LOG: received fast shutdown request
> LOG: aborting any active transactions
> LOG: shutting down
> LOG: restartpoint starting: shutdown immediate
>
> Some of us know that the "immediate" word refers to the restartpoint
> request, though that word causes conceptual conflict with the shutdown
> mode, which was fast, not immediate.
>
> Think we need to change the wording of this
>
> LOG: restartpoint starting: shutdown immediate
>
> so it is clearer what we mean
We *do* we mean? And why are we logging it?
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2009-12-16 15:42:13 |
| Message-ID: | 1260978133.634.1569.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
> On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> > running with log_checkpoints = on
> >
> > pg_ctl -D foo -m fast stop
> >
> > log says
> >
> > LOG: received fast shutdown request
> > LOG: aborting any active transactions
> > LOG: shutting down
> > LOG: restartpoint starting: shutdown immediate
> >
> > Some of us know that the "immediate" word refers to the restartpoint
> > request, though that word causes conceptual conflict with the shutdown
> > mode, which was fast, not immediate.
> >
> > Think we need to change the wording of this
> >
> > LOG: restartpoint starting: shutdown immediate
> >
> > so it is clearer what we mean
>
> We *do* we mean? And why are we logging it?
The words after the colon refer to options sent to RequestCheckpoint and
it is logged because we asked for it by doing log_checkpoints = on.
I suggest we say "smoothed" when checkpoint option is !immediate. So we
will remove the word "immediate" from the message.
--
Simon Riggs www.2ndQuadrant.com
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2009-12-18 12:57:59 |
| Message-ID: | 1261141079.28414.1.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On ons, 2009-12-16 at 15:42 +0000, Simon Riggs wrote:
> I suggest we say "smoothed" when checkpoint option is !immediate. So
> we
> will remove the word "immediate" from the message.
The opposite of smooth could be sharp. :)
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2010-02-19 19:48:56 |
| Message-ID: | 201002191948.o1JJmup05240@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
> > On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
> > > running with log_checkpoints = on
> > >
> > > pg_ctl -D foo -m fast stop
> > >
> > > log says
> > >
> > > LOG: received fast shutdown request
> > > LOG: aborting any active transactions
> > > LOG: shutting down
> > > LOG: restartpoint starting: shutdown immediate
> > >
> > > Some of us know that the "immediate" word refers to the restartpoint
> > > request, though that word causes conceptual conflict with the shutdown
> > > mode, which was fast, not immediate.
> > >
> > > Think we need to change the wording of this
> > >
> > > LOG: restartpoint starting: shutdown immediate
> > >
> > > so it is clearer what we mean
> >
> > We *do* we mean? And why are we logging it?
>
> The words after the colon refer to options sent to RequestCheckpoint and
> it is logged because we asked for it by doing log_checkpoints = on.
>
> I suggest we say "smoothed" when checkpoint option is !immediate. So we
> will remove the word "immediate" from the message.
Did we decide not the change this?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast or immediate shutdown |
| Date: | 2010-02-19 21:48:22 |
| Message-ID: | 603c8f071002191348p1ed8a985xf7a92a5fdaefca74@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Feb 19, 2010 at 2:48 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Simon Riggs wrote:
>> On Wed, 2009-12-16 at 17:04 +0200, Peter Eisentraut wrote:
>> > On tis, 2009-12-15 at 17:19 +0000, Simon Riggs wrote:
>> > > running with log_checkpoints = on
>> > >
>> > > pg_ctl -D foo -m fast stop
>> > >
>> > > log says
>> > >
>> > > LOG: received fast shutdown request
>> > > LOG: aborting any active transactions
>> > > LOG: shutting down
>> > > LOG: restartpoint starting: shutdown immediate
>> > >
>> > > Some of us know that the "immediate" word refers to the restartpoint
>> > > request, though that word causes conceptual conflict with the shutdown
>> > > mode, which was fast, not immediate.
>> > >
>> > > Think we need to change the wording of this
>> > >
>> > > LOG: restartpoint starting: shutdown immediate
>> > >
>> > > so it is clearer what we mean
>> >
>> > We *do* we mean? And why are we logging it?
>>
>> The words after the colon refer to options sent to RequestCheckpoint and
>> it is logged because we asked for it by doing log_checkpoints = on.
>>
>> I suggest we say "smoothed" when checkpoint option is !immediate. So we
>> will remove the word "immediate" from the message.
>
> Did we decide not the change this?
Personally, my opinion is that if we're going to print the message at
all, the names used for the message should match the names used in the
code. So -1 from me on calling it immediate in the code but smoothed
in the message. On the other hand, I have no personal attachment to
that message, so if other people feel it's not needed at all, I could
see removing it.
...Robert