| Lists: | pgsql-rrreviewers |
|---|
| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | "Robert Haas" <robertmhaas(at)gmail(dot)com> |
| Cc: | <pgsql-rrreviewers(at)postgresql(dot)org> |
| Subject: | Anything I can still do for this CF? |
| Date: | 2009-10-05 22:08:54 |
| Message-ID: | 4ACA2826020000250002B635@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-rrreviewers |
After a vacation without much Internet access, sandwiched between a
bunch of family emergencies, I'm now caught up on email and should be
in a position to try to do something useful in the PostgreSQL world
starting tomorrow. Is there anything I can do to help with a patch
review at this point, or should I focus on follow-up to the feedback I
got on the LSB init script? (Specifically, that is primarily about
identifying where pg_ctl doesn't currently "do the right thing" for
LSB conformance, so that we can discuss which of those differences
should be covered by changes to pg_ctl, and which should be left to
scripting.)
I'm happy to pitch in wherever I might be useful.
-Kevin
| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-rrreviewers(at)postgresql(dot)org |
| Subject: | Re: Anything I can still do for this CF? |
| Date: | 2009-10-05 22:47:54 |
| Message-ID: | 1254782874.368.26.camel@monkey-cat.sm.truviso.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-rrreviewers |
On Mon, 2009-10-05 at 17:08 -0500, Kevin Grittner wrote:
> Is there anything I can do to help with a patch
> review at this point
"Named and mixed notation support" could probably use a second pass
before a committer reviews it. Also, Robert Haas mentioned that "Lock
wait statistics" could use some more input.
"writable CTEs" is a cool feature, but it's run into some problems with
rules:
http://archives.postgresql.org/pgsql-hackers/2009-10/msg00242.php
If you have any ideas, perhaps that feature can be saved.
Regards,
Jeff Davis
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-rrreviewers(at)postgresql(dot)org |
| Subject: | Re: Anything I can still do for this CF? |
| Date: | 2009-10-05 23:57:59 |
| Message-ID: | 603c8f070910051657v1753fa4ev6b00ed6465134ec9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-rrreviewers |
On Mon, Oct 5, 2009 at 6:47 PM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> On Mon, 2009-10-05 at 17:08 -0500, Kevin Grittner wrote:
>> Is there anything I can do to help with a patch
>> review at this point
>
> "Named and mixed notation support" could probably use a second pass
> before a committer reviews it. Also, Robert Haas mentioned that "Lock
> wait statistics" could use some more input.
>
> "writable CTEs" is a cool feature, but it's run into some problems with
> rules:
>
> http://archives.postgresql.org/pgsql-hackers/2009-10/msg00242.php
>
> If you have any ideas, perhaps that feature can be saved.
I also think "Reworks for Access Controls" and "Largeobject access
controls" could also use some further looking over, and the ECPG
patches need a good bit of work too.
...Robert