Re: Thanks.

Folks,

I think we are about done with reviewing for CommitFest 2009-07.
Thanks to all who participated. I did not have a chance to read as
many of the patches as I had wished, but the reviews I saw seemed like
they were well-done and helpful to the patch authors. I particularly
appreciate the efforts of the people who reviewed multiple patches,
such as Andres Freund, Jaime Casanova, Jeff Davis, and Bernd Helmle.
I hope that many of you will volunteer again for the next CommitFest;
we had a great crop of reviewers this time and I feel like the process
went pretty smoothly.

Comments? Thoughts on how to do it better next time? Want to
volunteer to do something? Hit that reply button.

Thanks again to all.

...Robert

On Sun, 2009-08-09 at 22:06 -0400, Robert Haas wrote:
> Comments? Thoughts on how to do it better next time? Want to
> volunteer to do something? Hit that reply button.

I think we might want an additional returned status, like "Returned
Pending Discussion" to indicate that we, as a community, don't know
whether the patch is right or not.

For instance the "Parser's hook based on FuncCall" patch. I don't
necessarily feel like the author was given enough feedback to really
complete the patch, nor was it outright rejected.

There's no obvious solution, but maybe we should aim for some breathing
room in between commitfests so that the necessary discussion can happen.
I'm a little worried that with only a month, people will mostly be
working on their own features and waiting until the next commitfest to
really have any discussions.

This is somewhat selfish, because with the commitfest over, I'll be
trying to get my "Generalized Index Constraints" patch into shape. I'd
like to get feedback on a few specific things before I try to make a
commit-able version of the patch (with docs, psql/pg_dump support,
etc.).

Let me say that I also think the commitfest has been a tremendously
successful and efficient process. We got a lot of great submissions very
early in the 8.5 cycle, which will hopefully ease the schedule near
release time. So I might be worried about nothing at all.

Regards,
Jeff Davis

Robert,

> Comments? Thoughts on how to do it better next time? Want to
> volunteer to do something? Hit that reply button.

Thank *you*. You've done a spectacular job as CFM, far better than
either me or Dave. Are you up for another round, or do you want to take
one off to avoid burnout?

--
Josh Berkus
PostgreSQL Experts Inc.
www.pgexperts.com

On Mon, Aug 10, 2009 at 8:09 PM, Josh Berkus<josh(at)agliodbs(dot)com> wrote:
> Robert,
>
>> Comments?  Thoughts on how to do it better next time?  Want to
>> volunteer to do something?  Hit that reply button.
>
> Thank *you*.  You've done a spectacular job as CFM, far better than
> either me or Dave.  Are you up for another round, or do you want to take
> one off to avoid burnout?

You've pre-empted me Josh - I was just about to write roughly the same email :-)

Anyway - seconded; excellent job Robert!

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Josh Berkus<josh(at)agliodbs(dot)com> wrote:

>>> Comments? Thoughts on how to do it better next time? Want to
>>> volunteer to do something? Hit that reply button.
>>
>> Thank *you*. You've done a spectacular job as CFM, far better than
>> either me or Dave. Are you up for another round, or do you want to
>> take one off to avoid burnout?
>
> You've pre-empted me Josh - I was just about to write roughly the
> same email
> :-)
>
> Anyway - seconded; excellent job Robert!

I'd saved Robert's email to write a reply to the same effect. It's
hard to imagine it being done any better. Thank you, Robert!

-Kevin

On Mon, Aug 10, 2009 at 3:22 PM, Kevin
Grittner<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> Josh Berkus<josh(at)agliodbs(dot)com> wrote:
>
>>>> Comments?  Thoughts on how to do it better next time?  Want to
>>>> volunteer to do something?  Hit that reply button.
>>>
>>> Thank *you*.  You've done a spectacular job as CFM, far better than
>>> either me or Dave.  Are you up for another round, or do you want to
>>> take one off to avoid burnout?
>>
>> You've pre-empted me Josh - I was just about to write roughly the
>> same email
>> :-)
>>
>> Anyway - seconded; excellent job Robert!
>
> I'd saved Robert's email to write a reply to the same effect.  It's
> hard to imagine it being done any better.  Thank you, Robert!

Thanks, I really appreciate all of your kind words. I'm wondering,
though, if we can identify some of the particular things that I did
well, rather than just "everything". Since I suspect I'm going to end
up running another CommitFest at some point, it would be useful to
know what things that I did this time I should be sure to do again
next time. But, also, I don't think I'm up for running EVERY future
CommitFest, so somebody else is eventually going to need a list of
what to do and what to avoid.

I also think we should move this discussion to -hackers so that people
who are not following -rrreviewers but may have comments can throw in
their $0.02. Perhaps someone would volunteer to kick off a thread
there?

...Robert