| Lists: | pgsql-hackers |
|---|
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | pg_listener attribute number #defines |
| Date: | 2009-06-24 05:09:57 |
| Message-ID: | 603c8f070906232209j74b1d559q28ca381ed49f7c69@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
It appears that, for no particularly good reason, pg_listener.h
deviates from the usual convention for declaring attribute number
constants. Normally, it's
#define Anum_{catalog-name}_{column-name} {attribute-number}
pg_listener.h, however substitutes a different string that is similar,
but not the same as, the column name.
Suggested patch attached.
...Robert
| Attachment | Content-Type | Size |
|---|---|---|
| anum_pg_listener.patch | text/x-diff | 4.1 KB |
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: pg_listener attribute number #defines |
| Date: | 2009-07-21 20:25:19 |
| Message-ID: | 200907212325.20317.peter_e@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wednesday 24 June 2009 08:09:57 Robert Haas wrote:
> It appears that, for no particularly good reason, pg_listener.h
> deviates from the usual convention for declaring attribute number
> constants. Normally, it's
>
> #define Anum_{catalog-name}_{column-name} {attribute-number}
>
> pg_listener.h, however substitutes a different string that is similar,
> but not the same as, the column name.
>
> Suggested patch attached.
Fixed.