| Lists: | pgsql-hackers |
|---|
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Subject: | Re: change do_tup_output to take Datum arguments rather than cstring |
| Date: | 2009-06-16 04:58:32 |
| Message-ID: | 603c8f070906152158i19191b0fg417cfa4b883ffc65@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jun 15, 2009 at 1:20 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> it looks like I can probably rip that member out of TupOutputState
>> altogether.
>
>> Will update patch. Does this look like what you were thinking otherwise?
>
> Yeah, that's exactly what I was thinking.
Excellent. Revised patch attached.
...Robert
| Attachment | Content-Type | Size |
|---|---|---|
| do_tup_output_datum-v2.patch | text/x-diff | 7.3 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: change do_tup_output to take Datum arguments rather than cstring |
| Date: | 2009-07-22 17:03:49 |
| Message-ID: | 169.1248282229@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jun 15, 2009 at 1:20 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> it looks like I can probably rip that member out of TupOutputState
>>> altogether.
>>
>> Yeah, that's exactly what I was thinking.
> Excellent. Revised patch attached.
Applied with minor editorialization.
It strikes me that it would now be quite easy to make the
efficiency improvement alluded to in do_tup_output's comment:
* XXX This could be made more efficient, since in reality we probably only
* need a virtual tuple.
but I didn't have time to investigate that right now (got to leave for
a dentist appointment :-()
regards, tom lane