| Lists: | pgsql-hackers |
|---|
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RELKIND_SPECIAL |
| Date: | 2006-05-01 05:02:12 |
| Message-ID: | 20060501050211.GA2648@surnet.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
How about we remove RELKIND_SPECIAL? It was there only to support
the XactLockTable hack, but we don't need that anymore.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RELKIND_SPECIAL |
| Date: | 2006-05-01 14:40:07 |
| Message-ID: | 5622.1146494407@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> How about we remove RELKIND_SPECIAL? It was there only to support
> the XactLockTable hack, but we don't need that anymore.
Go for it. Don't forget to remove the documentation mentions
(catalog.sgml at least). Might be a good idea to leave the code
for the case in psql/describe.c, though, just so psql doesn't choke
if run on an old database?
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RELKIND_SPECIAL |
| Date: | 2006-05-28 03:32:53 |
| Message-ID: | 20060528033253.GB2540@surnet.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > How about we remove RELKIND_SPECIAL? It was there only to support
> > the XactLockTable hack, but we don't need that anymore.
>
> Go for it. Don't forget to remove the documentation mentions
> (catalog.sgml at least). Might be a good idea to leave the code
> for the case in psql/describe.c, though, just so psql doesn't choke
> if run on an old database?
Done. I didn't find any other mentions in the documentation; I grepped
for "special" and "relkind".
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.