| Lists: | pgsql-hackers |
|---|
| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | event trigger pg_dump fix |
| Date: | 2015-01-05 22:37:25 |
| Message-ID: | CALLjQTRt7c-8P3DrEGG3sz8Yw+_NkqFYO3ZVKRMZomeFejvRHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
Attached is fix for
http://www.postgresql.org/message-id/1420492505.23613.15.camel@bloodnok.com
It was dumping comment with NULL owner while the function expects
empty string for objects without owner (there is pg_strdup down the
line).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_evt_tigger_20150105.patch | text/x-patch | 471 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: event trigger pg_dump fix |
| Date: | 2015-01-06 00:02:40 |
| Message-ID: | 9663.1420502560@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
> Attached is fix for
> http://www.postgresql.org/message-id/1420492505.23613.15.camel@bloodnok.com
> It was dumping comment with NULL owner while the function expects
> empty string for objects without owner (there is pg_strdup down the
> line).
This isn't right either: event triggers do have owners.
regards, tom lane
| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: event trigger pg_dump fix |
| Date: | 2015-01-06 00:40:52 |
| Message-ID: | 54AB2F14.4060803@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 06/01/15 01:02, Tom Lane wrote:
> Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
>> Attached is fix for
>> http://www.postgresql.org/message-id/1420492505.23613.15.camel@bloodnok.com
>
>> It was dumping comment with NULL owner while the function expects
>> empty string for objects without owner (there is pg_strdup down the
>> line).
>
> This isn't right either: event triggers do have owners.
>
Bah, of course, stupid me.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_evt_tigger_20150106.patch | text/x-diff | 486 bytes |