| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | effective_io_concurrency documentation |
| Date: | 2014-09-29 17:41:38 |
| Message-ID: | 542999D2.6070909@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
The documentation of effective_io_concurrency says
Asynchronous I/O depends on an effective <function>posix_fadvise</>
function, which some operating systems lack. If the function is not
present then setting this parameter to anything but zero will result
in an error.
This is not correct, because on unsupported systems, it is an error to
set this parameter to anything, including zero, because it is set to
PGC_INTERNAL.
I think this is a mistake. For example, we allow setting ssl to false
even if SSL support is not compiled in.
I propose the attached patch to correct this.
| Attachment | Content-Type | Size |
|---|---|---|
| effective-io-concurrency-doc.patch | text/x-patch | 1.6 KB |
| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: effective_io_concurrency documentation |
| Date: | 2014-09-29 19:10:00 |
| Message-ID: | CAM3SWZQGjVu=vw07y=v9arEeqki1HFrw3PpHPkiqk=v5aWOEKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Sep 29, 2014 at 10:41 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> I think this is a mistake. For example, we allow setting ssl to false
> even if SSL support is not compiled in.
+1
--
Peter Geoghegan