| Lists: | pgsql-hackers |
|---|
| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Minor improvement to fdwhandler.sgml |
| Date: | 2014-04-24 11:59:46 |
| Message-ID: | 5358FCB2.3020403@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi all,
The patch attached improves docs in fdwhandler.sgml a little bit.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| doc-fdw-planning.patch | text/plain | 1.8 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor improvement to fdwhandler.sgml |
| Date: | 2014-04-28 14:31:32 |
| Message-ID: | CA+TgmobmhOikNrb1x_Ub2p0+mb4DHksS6RxVvaqBotWKDc6tjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> The patch attached improves docs in fdwhandler.sgml a little bit.
When you submit a patch, it's helpful to describe what the patch
actually does, rather than just saying it makes things better. For
example, I think that this patch could be described as "in
fdwhandler.sgml, mark references to scan_clauses with <structfield>
tags".
A problem with that idea is that scan_clauses is not a field in any struct.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor improvement to fdwhandler.sgml |
| Date: | 2014-04-30 08:10:50 |
| Message-ID: | 5360B00A.2020407@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
(2014/04/28 23:31), Robert Haas wrote:
> On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> The patch attached improves docs in fdwhandler.sgml a little bit.
>
> When you submit a patch, it's helpful to describe what the patch
> actually does, rather than just saying it makes things better. For
> example, I think that this patch could be described as "in
> fdwhandler.sgml, mark references to scan_clauses with <structfield>
> tags".
I thought so. Sorry, my explanation wasn't enough.
> A problem with that idea is that scan_clauses is not a field in any struct.
I was mistaken. I think those should be marked with <literal> tags.
Patch attached.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| doc-fdw-planning-2.patch | text/plain | 1.8 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor improvement to fdwhandler.sgml |
| Date: | 2014-05-05 14:05:16 |
| Message-ID: | CA+TgmobjgdB8_mufkJrsbycc527EsKHhO18FK+4arz5LMSO5Wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Apr 30, 2014 at 4:10 AM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> (2014/04/28 23:31), Robert Haas wrote:
>> On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>
>>> The patch attached improves docs in fdwhandler.sgml a little bit.
>>
>>
>> When you submit a patch, it's helpful to describe what the patch
>> actually does, rather than just saying it makes things better. For
>> example, I think that this patch could be described as "in
>> fdwhandler.sgml, mark references to scan_clauses with <structfield>
>> tags".
>
>
> I thought so. Sorry, my explanation wasn't enough.
>
>
>> A problem with that idea is that scan_clauses is not a field in any
>> struct.
>
>
> I was mistaken. I think those should be marked with <literal> tags. Patch
> attached.
OK, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor improvement to fdwhandler.sgml |
| Date: | 2014-05-08 02:40:55 |
| Message-ID: | 536AEEB7.3000302@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
(2014/05/05 23:05), Robert Haas wrote:
> On Wed, Apr 30, 2014 at 4:10 AM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> (2014/04/28 23:31), Robert Haas wrote:
>>> On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
>>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>>
>>>> The patch attached improves docs in fdwhandler.sgml a little bit.
>>>
>>>
>>> When you submit a patch, it's helpful to describe what the patch
>>> actually does, rather than just saying it makes things better. For
>>> example, I think that this patch could be described as "in
>>> fdwhandler.sgml, mark references to scan_clauses with <structfield>
>>> tags".
>>
>>
>> I thought so. Sorry, my explanation wasn't enough.
>>
>>
>>> A problem with that idea is that scan_clauses is not a field in any
>>> struct.
>>
>>
>> I was mistaken. I think those should be marked with <literal> tags. Patch
>> attached.
>
> OK, committed.
Thanks!
Best regards,
Etsuro Fujita