small typo about comment in xlog.c

Lists: pgsql-hackers
From: Tomonari Katsumata <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: small typo about comment in xlog.c
Date: 2014-04-10 04:19:28
Message-ID: 53461BD0.9050009@po.ntts.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

I'm reading xlog.c, and I noticed a comment of
do_pg_abort_backup is typo.

...
10247 * NB: This is only for aborting a non-exclusive backup that
doesn't write
10248 * backup_label. A backup started with pg_stop_backup() needs to be
finished
10249 * with pg_stop_backup().
...

I think "A backup started with pg_stop_backup()" should be
"A backup started with pg_start_backup()".

This is a bug about source comment, so it's not big problem.
But I want to fix the comment.
See attached patch.

regards,
--------------
Tomonari Katsumata

Attachment Content-Type Size
xlog-c_comment_typo.patch text/x-diff 593 bytes
From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Tomonari Katsumata <katsumata(dot)tomonari(at)po(dot)ntts(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: small typo about comment in xlog.c
Date: 2014-04-10 10:13:24
Message-ID: 53466EC4.3050507@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 04/10/2014 07:19 AM, Tomonari Katsumata wrote:
> Hi,
>
> I'm reading xlog.c, and I noticed a comment of
> do_pg_abort_backup is typo.
>
> ...
> 10247 * NB: This is only for aborting a non-exclusive backup that
> doesn't write
> 10248 * backup_label. A backup started with pg_stop_backup() needs to be
> finished
> 10249 * with pg_stop_backup().
> ...
>
> I think "A backup started with pg_stop_backup()" should be
> "A backup started with pg_start_backup()".
>
> This is a bug about source comment, so it's not big problem.
> But I want to fix the comment.
> See attached patch.

Fixed, thanks.

- Heikki