Re: unixware and --with-ldap

Lists: pgsql-hackerspgsql-patches
From: "Albe Laurenz" <all(at)adv(dot)magwien(dot)gv(dot)at>
To: <ohp(at)pyrenet(dot)fr>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers list" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unixware and --with-ldap
Date: 2006-12-18 08:31:35
Message-ID: 52EF20B2E3209443BC37736D00C3C1380BEC9729@EXADV1.host.magwien.gv.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

>>> If libldap_r.so does require the same libs, please add
$EXTRA_LDAP_LIBS
>>> to the 'LDAP_LIBS_FE="-lldap_r"' line as well.
>>
>> Actually, I did that in the patch-as-committed. It seems to me that
>> it's probably harmless even if not needed.
>
> I have tried --with-thread-safety and configure fails on ldap check
> because for some reason CTHREAD_FLAGS (-Kpthread for UW) is missing
> on compile command, although present before that. I can't find why

You mean PTHREAD_FLAGS, right?

If it is present in line 1118, it should also be present in line 1133.

Can you verify that the part on configure.in between 1065 and 1118,
-Kpthread is correctly set on Unixware?

If not, thread support for Unixware is probebly broken.

If yes, something strange is going on.

Yours,
Laurenz Albe


From: ohp(at)pyrenet(dot)fr
To: Albe Laurenz <all(at)adv(dot)magwien(dot)gv(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unixware and --with-ldap
Date: 2006-12-18 14:42:29
Message-ID: Pine.UW2.4.53.0612181531430.6029@sun.pyrenet
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches

Hi Albe,
On Mon, 18 Dec 2006, Albe Laurenz wrote:

> Date: Mon, 18 Dec 2006 09:31:35 +0100
> From: Albe Laurenz <all(at)adv(dot)magwien(dot)gv(dot)at>
> To: ohp(at)pyrenet(dot)fr, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Cc: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
> Subject: RE: [HACKERS] unixware and --with-ldap
>
> >>> If libldap_r.so does require the same libs, please add
> $EXTRA_LDAP_LIBS
> >>> to the 'LDAP_LIBS_FE="-lldap_r"' line as well.
> >>
> >> Actually, I did that in the patch-as-committed. It seems to me that
> >> it's probably harmless even if not needed.
> >
> > I have tried --with-thread-safety and configure fails on ldap check
> > because for some reason CTHREAD_FLAGS (-Kpthread for UW) is missing
> > on compile command, although present before that. I can't find why
>
> You mean PTHREAD_FLAGS, right?
>
Nope,I mean PTHREAD_CFLAGS witch is defined in src/templates/unixware
> If it is present in line 1118, it should also be present in line 1133.
>
> Can you verify that the part on configure.in between 1065 and 1118,
> -Kpthread is correctly set on Unixware?
>
It is defined, my guts felling is that AC_SUBSTs lines 1470,1471 do
something weird.
> If not, thread support for Unixware is probebly broken.
>
It is, because when searching for ldap_r succeeds by forcing
PTHREAD_CFLAGS to be used, configure still fails when testing for thread
safety compiling src/test/thread/thread_test.c.

This fails because unixware's sigwait has only one arg although (according
to doc you can see at http://www.pyrenet.fr:8458) it's thread safe...

> If yes, something strange is going on.
>
indeed
> Yours,
> Laurenz Albe
>

Best regards
--
Olivier PRENANT Tel: +33-5-61-50-97-00 (Work)
15, Chemin des Monges +33-5-61-50-97-01 (Fax)
31190 AUTERIVE +33-6-07-63-80-64 (GSM)
FRANCE Email: ohp(at)pyrenet(dot)fr
------------------------------------------------------------------------------
Make your life a dream, make your dream a reality. (St Exupery)


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Albe Laurenz <all(at)adv(dot)magwien(dot)gv(dot)at>
Cc: ohp(at)pyrenet(dot)fr, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] unixware and --with-ldap
Date: 2007-02-03 02:44:27
Message-ID: 200702030244.l132iRu01969@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers pgsql-patches


Patch attached and applied. Sorry for the delay. Backpatched to 8.2.X.

---------------------------------------------------------------------------

Albe Laurenz wrote:
> >>> If libldap_r.so does require the same libs, please add
> $EXTRA_LDAP_LIBS
> >>> to the 'LDAP_LIBS_FE="-lldap_r"' line as well.
> >>
> >> Actually, I did that in the patch-as-committed. It seems to me that
> >> it's probably harmless even if not needed.
> >
> > I have tried --with-thread-safety and configure fails on ldap check
> > because for some reason CTHREAD_FLAGS (-Kpthread for UW) is missing
> > on compile command, although present before that. I can't find why
>
> You mean PTHREAD_FLAGS, right?
>
> If it is present in line 1118, it should also be present in line 1133.
>
> Can you verify that the part on configure.in between 1065 and 1118,
> -Kpthread is correctly set on Unixware?
>
> If not, thread support for Unixware is probebly broken.
>
> If yes, something strange is going on.
>
> Yours,
> Laurenz Albe
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
/rtmp/diff text/x-diff 1.7 KB