| Lists: | pgsql-hackers |
|---|
| From: | Brar Piening <brar(at)gmx(dot)de> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Visual Studio 2013 build |
| Date: | 2013-12-02 22:12:28 |
| Message-ID: | 529D05CC.7070806@gmx.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hackers,
the attached patch enables Microsoft Visual Studio 2013 as additional
build environment.
After some tweaking (VS now has got its own rint and a few macro
definitions that were previously missing) the build runs without errors
or warnings and the product passes the regression tests.
I didn't test any special configurations though.
I'm using full Visual Studio 2013 actually so I can't conform that
everything still works with Visual Studio Express 2013 for Windows
Desktop, but there are no documented limitations that make any problems
foreseeable.
I will add it to the CommitFest 2014-01 so that there is time for
testing and tweaking.
Regards,
Brar
| Attachment | Content-Type | Size |
|---|---|---|
| VS2013_01.patch | text/plain | 11.5 KB |
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Visual Studio 2013 build |
| Date: | 2013-12-02 22:48:30 |
| Message-ID: | 529D0E3E.3020109@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/02/2013 02:12 PM, Brar Piening wrote:
> Hackers,
> the attached patch enables Microsoft Visual Studio 2013 as additional
> build environment.
> After some tweaking (VS now has got its own rint and a few macro
> definitions that were previously missing) the build runs without errors
> or warnings and the product passes the regression tests.
> I didn't test any special configurations though.
> I'm using full Visual Studio 2013 actually so I can't conform that
> everything still works with Visual Studio Express 2013 for Windows
> Desktop, but there are no documented limitations that make any problems
> foreseeable.
> I will add it to the CommitFest 2014-01 so that there is time for
> testing and tweaking.
Wow, thanks for doing this!
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Brar Piening <brar(at)gmx(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Visual Studio 2013 build |
| Date: | 2014-01-26 00:13:25 |
| Message-ID: | 52E45325.5050805@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/02/2013 05:12 PM, Brar Piening wrote:
> Hackers,
> the attached patch enables Microsoft Visual Studio 2013 as additional
> build environment.
> After some tweaking (VS now has got its own rint and a few macro
> definitions that were previously missing) the build runs without
> errors or warnings and the product passes the regression tests.
> I didn't test any special configurations though.
> I'm using full Visual Studio 2013 actually so I can't conform that
> everything still works with Visual Studio Express 2013 for Windows
> Desktop, but there are no documented limitations that make any
> problems foreseeable.
> I will add it to the CommitFest 2014-01 so that there is time for
> testing and tweaking.
>
OK, I have tested this out with the development branch and Visual Studio
Express 2013 for Windows Desktop, on Windows Server 2008 R2-SP1 64 bit.
With a slight adjustment to make the patch apply it works fine.
How far back should we go? About a year ago when we did this we applied
it for 9.2 (then the latest stable release) and 9.3dev.
cheers
andrew
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Visual Studio 2013 build |
| Date: | 2014-01-26 10:44:12 |
| Message-ID: | CABUevEyZbwDBp_kUDS2vbW-gktY5WUQc3NkkYnvs0_qq+bO7mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sun, Jan 26, 2014 at 1:13 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 12/02/2013 05:12 PM, Brar Piening wrote:
>
>> Hackers,
>> the attached patch enables Microsoft Visual Studio 2013 as additional
>> build environment.
>> After some tweaking (VS now has got its own rint and a few macro
>> definitions that were previously missing) the build runs without errors or
>> warnings and the product passes the regression tests.
>> I didn't test any special configurations though.
>> I'm using full Visual Studio 2013 actually so I can't conform that
>> everything still works with Visual Studio Express 2013 for Windows
>> Desktop, but there are no documented limitations that make any problems
>> foreseeable.
>> I will add it to the CommitFest 2014-01 so that there is time for testing
>> and tweaking.
>>
>>
>
> OK, I have tested this out with the development branch and Visual Studio
> Express 2013 for Windows Desktop, on Windows Server 2008 R2-SP1 64 bit.
> With a slight adjustment to make the patch apply it works fine.
>
> How far back should we go? About a year ago when we did this we applied it
> for 9.2 (then the latest stable release) and 9.3dev.
>
Seems reasonable to follow the same pattern, and apply it for 9.3 stable
and 9.4dev. The argument being that it's a new build env, and it's not
likely that people are going to use that t o build very old versions of
postgres.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/