| Lists: | pgsql-hackers |
|---|
| From: | Haribabu kommi <haribabu(dot)kommi(at)huawei(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Ident context leak during reloading of conf files when no ident information is present in the file |
| Date: | 2013-10-24 10:20:48 |
| Message-ID: | 8977CB36860C5843884E0A18D8747B0372BCA1AB@szxeml558-mbs.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
There is an ident context leak which is occurs during reload of configuration files when
there is no ident configuration items are present in the configuration file.
In function load_ident(), New context is allocated to store the new_parsed_lines and deletes
the old context when parsed_ident_lines are present. If no parsed_ident_lines are present then
the context is not deleted.
Patch with fix is attached in the mail. please review and let me know your suggestions.
Regards,
Hari babu.
| Attachment | Content-Type | Size |
|---|---|---|
| ident_leak_v1.patch | application/octet-stream | 606 bytes |
| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Haribabu kommi <haribabu(dot)kommi(at)huawei(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ident context leak during reloading of conf files when no ident information is present in the file |
| Date: | 2013-10-24 11:09:18 |
| Message-ID: | 5268FFDE.1040506@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 24.10.2013 13:20, Haribabu kommi wrote:
> There is an ident context leak which is occurs during reload of configuration files when
> there is no ident configuration items are present in the configuration file.
>
> In function load_ident(), New context is allocated to store the new_parsed_lines and deletes
> the old context when parsed_ident_lines are present. If no parsed_ident_lines are present then
> the context is not deleted.
>
> Patch with fix is attached in the mail. please review and let me know your suggestions.
Thanks, committed.
- Heikki