Re: slightly confusing JSON error context

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: slightly confusing JSON error context
Date: 2013-06-20 01:19:18
Message-ID: 1371691158.13762.35.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

These are some cases from the regression tests:

SELECT ''::json; -- ERROR, no value
ERROR: invalid input syntax for type json
LINE 1: SELECT ''::json;
^
DETAIL: The input string ended unexpectedly.
CONTEXT: JSON data, line 1:

SELECT ' '::json; -- ERROR, no value
ERROR: invalid input syntax for type json
LINE 1: SELECT ' '::json;
^
DETAIL: The input string ended unexpectedly.
CONTEXT: JSON data, line 1:

Perhaps we should either put some quotes around the whitespace at the
end of the CONTEXT lines, or write something like "end of input".
Otherwise this might look weird. There might be more complicated cases
where it looks even weirder.


From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: slightly confusing JSON error context
Date: 2013-06-20 02:35:53
Message-ID: 51C26A89.9010303@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 06/19/2013 09:19 PM, Peter Eisentraut wrote:
> These are some cases from the regression tests:
>
> SELECT ''::json; -- ERROR, no value
> ERROR: invalid input syntax for type json
> LINE 1: SELECT ''::json;
> ^
> DETAIL: The input string ended unexpectedly.
> CONTEXT: JSON data, line 1:
>
> SELECT ' '::json; -- ERROR, no value
> ERROR: invalid input syntax for type json
> LINE 1: SELECT ' '::json;
> ^
> DETAIL: The input string ended unexpectedly.
> CONTEXT: JSON data, line 1:
>
> Perhaps we should either put some quotes around the whitespace at the
> end of the CONTEXT lines, or write something like "end of input".
> Otherwise this might look weird. There might be more complicated cases
> where it looks even weirder.
>

It's been that way since 9.2. I at least have no problem if you want to
make improvements.

cheers

andrew