Re: Matview patch added rewriteDefine.c.orig to the repository

Hi,

commit 3bf3ab8c563699138be02f9dc305b7b77a724307
("Add a materialized view relations.") added this:

src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
...
create mode 100644 src/backend/rewrite/rewriteDefine.c.orig

Committers should be more careful if they want to do work late Sunday.
I know, Monday begins on Saturday[1], but still... ;-)

[1] http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/

On 4 March 2013 06:39, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:

> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
> ("Add a materialized view relations.") added this:
>
> src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
> ...
> create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>
> Committers should be more careful if they want to do work late Sunday.
> I know, Monday begins on Saturday[1], but still... ;-)

AFAICS Kevin fixed this last night...

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Hi,

Kevin already removed it with a followup commit:

http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179

Regards, Devrim

Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:

>Hi,
>
>commit 3bf3ab8c563699138be02f9dc305b7b77a724307
>("Add a materialized view relations.") added this:
>
> src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
>...
> create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>
>Committers should be more careful if they want to do work late Sunday.
>I know, Monday begins on Saturday[1], but still... ;-)
>
>[1] http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday
>
>Best regards,
>Zoltán Böszörményi
>
>--
>----------------------------------
>Zoltán Böszörményi
>Cybertec Schönig & Schönig GmbH
>Gröhrmühlgasse 26
>A-2700 Wiener Neustadt, Austria
>Web: http://www.postgresql-support.de
> http://www.postgresql.at/
>
>
>
>--
>Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>To make changes to your subscription:
>http://www.postgresql.org/mailpref/pgsql-hackers

--
Devrim Gündüz

2013-03-04 08:02 keltezéssel, Simon Riggs írta:
> On 4 March 2013 06:39, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>
>> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
>> ("Add a materialized view relations.") added this:
>>
>> src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
>> ...
>> create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>>
>> Committers should be more careful if they want to do work late Sunday.
>> I know, Monday begins on Saturday[1], but still... ;-)
> AFAICS Kevin fixed this last night...
>

Did he? I just did this:

[zozo(at)localhost postgresql]$ git branch -a
* master
remotes/origin/HEAD -> origin/master
remotes/origin/REL2_0B
remotes/origin/REL6_4
remotes/origin/REL6_5_PATCHES
remotes/origin/REL7_0_PATCHES
remotes/origin/REL7_1_STABLE
remotes/origin/REL7_2_STABLE
remotes/origin/REL7_3_STABLE
remotes/origin/REL7_4_STABLE
remotes/origin/REL8_0_STABLE
remotes/origin/REL8_1_STABLE
remotes/origin/REL8_2_STABLE
remotes/origin/REL8_3_STABLE
remotes/origin/REL8_4_STABLE
remotes/origin/REL8_5_ALPHA1_BRANCH
remotes/origin/REL8_5_ALPHA2_BRANCH
remotes/origin/REL8_5_ALPHA3_BRANCH
remotes/origin/REL9_0_ALPHA4_BRANCH
remotes/origin/REL9_0_ALPHA5_BRANCH
remotes/origin/REL9_0_STABLE
remotes/origin/REL9_1_STABLE
remotes/origin/REL9_2_STABLE
remotes/origin/Release_1_0_3
remotes/origin/WIN32_DEV
remotes/origin/ecpg_big_bison
remotes/origin/master
[zozo(at)localhost postgresql]$ cat .git/config
[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates = true
[remote "origin"]
fetch = +refs/heads/*:refs/remotes/origin/*
url = git://git.postgresql.org/git/postgresql.git
[branch "master"]
remote = origin
merge = refs/heads/master
[zozo(at)localhost postgresql]$ git pull origin
Already up-to-date.
[zozo(at)localhost postgresql]$ find . -name "*.orig"
./src/backend/rewrite/rewriteDefine.c.orig

The main repo at http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary
only shows one followup commit (just as in my local copy):
bc61878682051678ade5f59da7bfd90ab72ce13b
"Fix map_sql_value_to_xml_value() to treat domains like their base types."

In which branch was this fixed?

Thanks,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/

2013-03-04 08:10 keltezéssel, Devrim Gündüz írta:
> Hi,
>
> Kevin already removed it with a followup commit:
>
> http://git.postgresql.org/pg/commitdiff/d63977eea3ab18fdec05e370b633d10b9fd20179

404 - Unknown commit object

>
> Regards, Devrim
>
> Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>
> Hi,
>
> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
> ("Add a materialized view relations.") added this:
>
> src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
> ...
> create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>
> Committers should be more careful if they want to do work late Sunday.
> I know, Monday begins on Saturday[1], but still... ;-)
>
> [1]http://en.wikipedia.org/wiki/Monday_Begins_on_Saturday
>
> Best regards,
> Zoltán Böszörményi
>
>
> --
> Devrim Gündüz

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/

On Mar 4, 2013 10:55 AM, "Boszormenyi Zoltan" <zb(at)cybertec(dot)at> wrote:
>
> 2013-03-04 08:02 keltezéssel, Simon Riggs írta:
>
>> On 4 March 2013 06:39, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>>
>>> commit 3bf3ab8c563699138be02f9dc305b7b77a724307
>>> ("Add a materialized view relations.") added this:
>>>
>>> src/backend/rewrite/rewriteDefine.c.orig | 945 +++++++++++++...
>>> ...
>>> create mode 100644 src/backend/rewrite/rewriteDefine.c.orig
>>>
>>> Committers should be more careful if they want to do work late Sunday.
>>> I know, Monday begins on Saturday[1], but still... ;-)
>>
>> AFAICS Kevin fixed this last night...
>>
>
> Did he? I just did this:
>
> [zozo(at)localhost postgresql]$ git branch -a
> * master
> remotes/origin/HEAD -> origin/master
> remotes/origin/REL2_0B
> remotes/origin/REL6_4
> remotes/origin/REL6_5_PATCHES
> remotes/origin/REL7_0_PATCHES
> remotes/origin/REL7_1_STABLE
> remotes/origin/REL7_2_STABLE
> remotes/origin/REL7_3_STABLE
> remotes/origin/REL7_4_STABLE
> remotes/origin/REL8_0_STABLE
> remotes/origin/REL8_1_STABLE
> remotes/origin/REL8_2_STABLE
> remotes/origin/REL8_3_STABLE
> remotes/origin/REL8_4_STABLE
> remotes/origin/REL8_5_ALPHA1_BRANCH
> remotes/origin/REL8_5_ALPHA2_BRANCH
> remotes/origin/REL8_5_ALPHA3_BRANCH
> remotes/origin/REL9_0_ALPHA4_BRANCH
> remotes/origin/REL9_0_ALPHA5_BRANCH
> remotes/origin/REL9_0_STABLE
> remotes/origin/REL9_1_STABLE
> remotes/origin/REL9_2_STABLE
> remotes/origin/Release_1_0_3
> remotes/origin/WIN32_DEV
> remotes/origin/ecpg_big_bison
> remotes/origin/master
> [zozo(at)localhost postgresql]$ cat .git/config
> [core]
> repositoryformatversion = 0
> filemode = true
> bare = false
> logallrefupdates = true
> [remote "origin"]
> fetch = +refs/heads/*:refs/remotes/origin/*
> url = git://git.postgresql.org/git/postgresql.git
> [branch "master"]
> remote = origin
> merge = refs/heads/master
> [zozo(at)localhost postgresql]$ git pull origin
> Already up-to-date.
> [zozo(at)localhost postgresql]$ find . -name "*.orig"
> ./src/backend/rewrite/rewriteDefine.c.orig
>
> The main repo at
http://git.postgresql.org/gitweb/?p=postgresql.git;a=summary
> only shows one followup commit (just as in my local copy):
> bc61878682051678ade5f59da7bfd90ab72ce13b
> "Fix map_sql_value_to_xml_value() to treat domains like their base types."
>
> In which branch was this fixed?

The repository is currently broken. There's a thread on www about it, and
also see the email to hackers a few hours ago telling committers to stop
pushing until it's fixed.

/Magnus

2013-03-04 13:01 keltezéssel, Magnus Hagander írta:
>
> The repository is currently broken. There's a thread on www about it, and also see the
> email to hackers a few hours ago telling committers to stop pushing until it's fixed.
>

Thanks for the info, I didn't know about it. I am not
subscribed to -www and I accidentally skipped your mail, too.

Best regards,
Zoltán Böszörményi

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/