| Lists: | pgsql-hackers |
|---|
| From: | Jiang Guiqing <jianggq(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | [PATCH] Patch to fix libecpg.so for isinf missing |
| Date: | 2012-12-03 05:12:48 |
| Message-ID: | 50BC34D0.7070503@cn.fujitsu.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
hi
isinf() is not build to libecpg.so if build and install postgresql by
source on solaris9.
(isinf() is not contained within solaris9 system.)
bash-2.05$ nm /usr/local/pgsql/lib/libecpg.so | grep isinf
[215] | 0| 0|FUNC |GLOB |0 |UNDEF |isinf
It(isinf missing) will causes ecpg program compile error such as follows.
bash-2.05$ ecpg test.pgc
bash-2.05$ cc -I/usr/local/pgsql/include -L/usr/local/pgsql/lib -lecpg
test.c -o test
Undefined first referenced
symbol in file
isinf /usr/local/pgsql/lib/libecpg.so
ld: fatal: Symbol referencing errors. No output written to test
I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
The diff file refer to the attachment "ecpglib-Makefile.patch".
Regards,
Jiang Guiqing
| Attachment | Content-Type | Size |
|---|---|---|
| test.pgc | text/plain | 188 bytes |
| ecpglib-Makefile.patch | text/plain | 1.1 KB |
| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Jiang Guiqing <jianggq(at)cn(dot)fujitsu(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Patch to fix libecpg.so for isinf missing |
| Date: | 2012-12-04 15:45:16 |
| Message-ID: | 20121204154516.GA8400@feivel.credativ.lan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Dec 03, 2012 at 01:12:48PM +0800, Jiang Guiqing wrote:
> isinf() is not build to libecpg.so if build and install postgresql
> by source on solaris9.
> (isinf() is not contained within solaris9 system.)
> ...
> I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
> The diff file refer to the attachment "ecpglib-Makefile.patch".
Thanks for finding and fixing the problem, patch committed to HEAD and all 9.* branches.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Jiang Guiqing <jianggq(at)cn(dot)fujitsu(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Patch to fix libecpg.so for isinf missing |
| Date: | 2012-12-04 17:31:28 |
| Message-ID: | 20121204173128.GA14799@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Dec 4, 2012 at 04:45:16PM +0100, Michael Meskes wrote:
> On Mon, Dec 03, 2012 at 01:12:48PM +0800, Jiang Guiqing wrote:
> > isinf() is not build to libecpg.so if build and install postgresql
> > by source on solaris9.
> > (isinf() is not contained within solaris9 system.)
> > ...
> > I modify src/interfaces/ecpg/ecpglib/Makefile to resolve this problem.
> > The diff file refer to the attachment "ecpglib-Makefile.patch".
>
> Thanks for finding and fixing the problem, patch committed to HEAD and all 9.* branches.
I have applied the attached patch to 9.0 to fix a merge conflict. I
patterned it after the commits you did to the other branches.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| Attachment | Content-Type | Size |
|---|---|---|
| merge.diff | text/x-diff | 1.1 KB |
| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Jiang Guiqing <jianggq(at)cn(dot)fujitsu(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Patch to fix libecpg.so for isinf missing |
| Date: | 2012-12-04 18:06:02 |
| Message-ID: | 20121204180602.GA13008@feivel.credativ.lan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Dec 04, 2012 at 12:31:28PM -0500, Bruce Momjian wrote:
> I have applied the attached patch to 9.0 to fix a merge conflict. I
> patterned it after the commits you did to the other branches.
That is interesting. I fixed the same conflict and my git showed the commit,
but apparently that upush didn't work correctly. Sorry.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL