[PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.

Lists: pgsql-hackers
From: JiangGuiqing <jianggq(at)cn(dot)fujitsu(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.
Date: 2012-11-19 06:03:31
Message-ID: 50A9CBB3.8010909@cn.fujitsu.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

hi

I install postgresql-9.1.5 from source code on windows successfully.
But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
installed lib directory .
If someone used functions of pgtypes or ecpg_compat library in ecpg
programs,the ecpg program build will fail.

So i modify src/tools/msvc/Install.pm to resolve this problem.
The diff file refer to the attachment "Install.pm.patch".

Regards,
Jiang Guiqing

Attachment Content-Type Size
Install.pm.patch text/plain 541 bytes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: JiangGuiqing <jianggq(at)cn(dot)fujitsu(dot)com>
Subject: Re: [PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.
Date: 2013-01-08 03:16:56
Message-ID: 1357615016.19347.5.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, 2012-11-19 at 14:03 +0800, JiangGuiqing wrote:
> hi
>
> I install postgresql-9.1.5 from source code on windows successfully.
> But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
> installed lib directory .
> If someone used functions of pgtypes or ecpg_compat library in ecpg
> programs,the ecpg program build will fail.
>
> So i modify src/tools/msvc/Install.pm to resolve this problem.
> The diff file refer to the attachment "Install.pm.patch".

Could someone with access to Windows verify this patch?


From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, JiangGuiqing <jianggq(at)cn(dot)fujitsu(dot)com>
Subject: Re: [PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.
Date: 2013-01-09 16:37:59
Message-ID: CABUevEzNyn4u1bKfSbW3+CkoXUV5RV+TYXc68sGN3BQk=VdXMw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jan 8, 2013 at 4:16 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Mon, 2012-11-19 at 14:03 +0800, JiangGuiqing wrote:
>> hi
>>
>> I install postgresql-9.1.5 from source code on windows successfully.
>> But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
>> installed lib directory .
>> If someone used functions of pgtypes or ecpg_compat library in ecpg
>> programs,the ecpg program build will fail.
>>
>> So i modify src/tools/msvc/Install.pm to resolve this problem.
>> The diff file refer to the attachment "Install.pm.patch".
>
> Could someone with access to Windows verify this patch?

Thta version doesn't even apply to 9.1 - only to master. And the
indent on master is really bad.

That said, function looks good, so I've cleaned i tup and applied.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/