Re: git trunk doesn't build

http://pastebin.com/RjiRjGZc

this is on fedora 12, gcc 4.6.1

--
GJ

On 07.11.2011 13:14, Gregg Jaskiewicz wrote:
> http://pastebin.com/RjiRjGZc
>
> this is on fedora 12, gcc 4.6.1

> rangetypes.c: In function ‘tsrange_subdiff’:
> rangetypes.c:1316:11: error: ‘timestamp’ undeclared (first use in this function)
> rangetypes.c:1316:11: note: each undeclared identifier is reported only once for each function it appears in
> rangetypes.c:1310:12: warning: unused variable ‘v2’ [-Wunused-variable]
> rangetypes.c:1309:12: warning: unused variable ‘v1’ [-Wunused-variable]
> rangetypes.c: In function ‘tstzrange_subdiff’:
> rangetypes.c:1332:11: error: ‘timestamp’ undeclared (first use in this function)
> rangetypes.c:1326:12: warning: unused variable ‘v2’ [-Wunused-variable]
> rangetypes.c:1325:12: warning: unused variable ‘v1’ [-Wunused-variable]

Looks like the range types patch was broken for float timestamps. I'll
go fix that. Thanks for the report!

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

On 7 November 2011 11:57, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:

> Looks like the range types patch was broken for float timestamps. I'll go
> fix that. Thanks for the report!

yup, no probs.

--
GJ

On 7 November 2011 11:57, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 07.11.2011 13:14, Gregg Jaskiewicz wrote:
>>
>> http://pastebin.com/RjiRjGZc
>>
>> this is on fedora 12, gcc 4.6.1
>
>> rangetypes.c: In function ‘tsrange_subdiff’:
>> rangetypes.c:1316:11: error: ‘timestamp’ undeclared (first use in this
>> function)
>> rangetypes.c:1316:11: note: each undeclared identifier is reported only
>> once for each function it appears in
>> rangetypes.c:1310:12: warning: unused variable ‘v2’ [-Wunused-variable]
>> rangetypes.c:1309:12: warning: unused variable ‘v1’ [-Wunused-variable]
>> rangetypes.c: In function ‘tstzrange_subdiff’:
>> rangetypes.c:1332:11: error: ‘timestamp’ undeclared (first use in this
>> function)
>> rangetypes.c:1326:12: warning: unused variable ‘v2’ [-Wunused-variable]
>> rangetypes.c:1325:12: warning: unused variable ‘v1’ [-Wunused-variable]
>
> Looks like the range types patch was broken for float timestamps. I'll go
> fix that. Thanks for the report!

I notice that there are no machines in the build farm which build HEAD
and use float timestamps, so this could silently happen again unless
the Grzegorz Jaskiewiczs out there continue to report build issues.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 7 November 2011 12:14, Thom Brown <thom(at)linux(dot)com> wrote:
>
> I notice that there are no machines in the build farm which build HEAD
> and use float timestamps, so this could silently happen again unless
> the Grzegorz Jaskiewiczs out there continue to report build issues.

I am rebuilding head once a week-ish for my own tests, but I don't
have any build farm for that matter.
It shouldn't be much of a hassle for me to create one that would
rebuild it with float timestamps.
Historically, that's what I have and I need to continue to use it that
way. Otherwise pg_upgrade won't work for me, and it's not an option on
big databases really.

Are the build scripts open/available ?

--
GJ

Gregg Jaskiewicz <gryzman(at)gmail(dot)com> wrote:
> On 7 November 2011 12:14, Thom Brown <thom(at)linux(dot)com> wrote:
>>
>> I notice that there are no machines in the build farm which build
>> HEAD and use float timestamps, so this could silently happen
>> again unless the Grzegorz Jaskiewiczs out there continue to
>> report build issues.
>
> I am rebuilding head once a week-ish for my own tests, but I don't
> have any build farm for that matter.
> It shouldn't be much of a hassle for me to create one that would
> rebuild it with float timestamps.
> Historically, that's what I have and I need to continue to use it
> that way. Otherwise pg_upgrade won't work for me, and it's not an
> option on big databases really.
>
> Are the build scripts open/available ?

http://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto

-Kevin

On 11/07/2011 09:40 AM, Kevin Grittner wrote:
> Gregg Jaskiewicz<gryzman(at)gmail(dot)com> wrote:
>> On 7 November 2011 12:14, Thom Brown<thom(at)linux(dot)com> wrote:
>>> I notice that there are no machines in the build farm which build
>>> HEAD and use float timestamps, so this could silently happen
>>> again unless the Grzegorz Jaskiewiczs out there continue to
>>> report build issues.
>> I am rebuilding head once a week-ish for my own tests, but I don't
>> have any build farm for that matter.
>> It shouldn't be much of a hassle for me to create one that would
>> rebuild it with float timestamps.
>> Historically, that's what I have and I need to continue to use it
>> that way. Otherwise pg_upgrade won't work for me, and it's not an
>> option on big databases really.
>>
>> Are the build scripts open/available ?
>
> http://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto
>
>

Yeah. I just updated this and the buildfarm web site to point to GitHub
where the code and releases now live.

cheers

andrew

On 07.11.2011 14:01, Gregg Jaskiewicz wrote:
> On 7 November 2011 11:57, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>
>> Looks like the range types patch was broken for float timestamps. I'll go
>> fix that. Thanks for the report!
>
> yup, no probs.

Fixed.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

On 7 Nov 2011, at 15:44, Heikki Linnakangas wrote:

> On 07.11.2011 14:01, Gregg Jaskiewicz wrote:
>> On 7 November 2011 11:57, Heikki Linnakangas
>> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
>>
>>> Looks like the range types patch was broken for float timestamps. I'll go
>>> fix that. Thanks for the report!
>>
>> yup, no probs.
>
> Fixed.
Thank You.