Re: BUG #6074: postgresql service script

Lists: pgsql-bugs
From: "Tomas Enrique Cardozo Baudry" <tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com>
To: pgsql-bugs(at)postgresql(dot)org
Subject: BUG #6074: postgresql service script
Date: 2011-06-22 12:47:29
Message-ID: 201106221247.p5MClS5R015725@wwwmaster.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs


The following bug has been logged online:

Bug reference: 6074
Logged by: Tomas Enrique Cardozo Baudry
Email address: tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com
PostgreSQL version: 8.4.4
Operating system: Centos 5.6
Description: postgresql service script
Details:

configuring the posgresql.conf on another port the service doesnt load the
port variable, because in the postgresql service script is a variable PGPORT
and this rewrite the configuration variable

solution (replace the port number with a script variable reader):

PGDATA=/var/lib/pgsql/data
#PGPORT=5432 #### <--- this is the bug
PGPORT=`/bin/cat $PGDATA/postgresql.conf | /bin/grep ’^port' | /bin/sed
's/port = //g'`

tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com, deshn(dot)co(dot)cc(at)gmail(dot)com
http://deshn.wikidot.com/howtos:bases-de-datos:postgresql:pgsql-service-scri
pt


From: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>
To: Tomas Enrique Cardozo Baudry <tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6074: postgresql service script
Date: 2011-06-23 03:35:37
Message-ID: 4E02B489.6070104@postnewspapers.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On 22/06/11 20:47, Tomas Enrique Cardozo Baudry wrote:
>
> The following bug has been logged online:
>
> Bug reference: 6074
> Logged by: Tomas Enrique Cardozo Baudry
> Email address: tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com
> PostgreSQL version: 8.4.4
> Operating system: Centos 5.6
> Description: postgresql service script
> Details:
>
> configuring the posgresql.conf on another port the service doesnt load the
> port variable, because in the postgresql service script is a variable PGPORT
> and this rewrite the configuration variable

I'm pretty sure that init script is part of CentOS (probably really part
of Red Hat Enterprise Linux), not part of PostgreSQL.

The script should *not* respect values from the environment; it's a good
thing that it doesn't. Otherwise setting PGPORT to tell psql what to do
would as a side effect change what port the server listened on if you
restarted it from that shell!

What the script should do is get those settings from /etc/sysconfig or
/etc/default (dunno which CentOS uses) so you don't have to hack the
init script directly.

--
Craig Ringer


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>
Cc: Tomas Enrique Cardozo Baudry <tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6074: postgresql service script
Date: 2011-06-23 03:52:13
Message-ID: 13224.1308801133@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

Craig Ringer <craig(at)postnewspapers(dot)com(dot)au> writes:
> On 22/06/11 20:47, Tomas Enrique Cardozo Baudry wrote:
>> configuring the posgresql.conf on another port the service doesnt load the
>> port variable, because in the postgresql service script is a variable PGPORT
>> and this rewrite the configuration variable

> I'm pretty sure that init script is part of CentOS (probably really part
> of Red Hat Enterprise Linux), not part of PostgreSQL.

The relevant part of the RHEL5 initscript is

# Set defaults for configuration variables
PGENGINE=/usr/bin
PGPORT=5432
PGDATA=/var/lib/pgsql/data
PGLOG=/var/lib/pgsql/pgstartup.log

# Override defaults from /etc/sysconfig/pgsql if file is present
[ -f /etc/sysconfig/pgsql/${NAME} ] && . /etc/sysconfig/pgsql/${NAME}

As this indicates, you are supposed to change those settings with a
script in /etc/sysconfig/pgsql/ if you need to change 'em. It's
intentional that those settings win out over postgresql.conf.

I'm not entirely sure that the OP is using the RHEL RPMs, though,
because the fragment he quoted didn't quite match this.

regards, tom lane


From: Dave Page <dpage(at)pgadmin(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Tomas Enrique Cardozo Baudry <tomas(dot)enrique(dot)cardozo(dot)baudry(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6074: postgresql service script
Date: 2011-06-23 07:35:45
Message-ID: BANLkTikF_=t-XhV9uvrBgy3pKcbiWFqtQQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Thu, Jun 23, 2011 at 4:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I'm not entirely sure that the OP is using the RHEL RPMs, though,
> because the fragment he quoted didn't quite match this.
>

It doesn't look like the script from the installers either.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company