Re: Disable optimization when in subtransaction

Lists: pgsql-hackers
From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>
Subject: Disable optimization when in subtransaction
Date: 2011-04-04 18:38:59
Message-ID: 4D99C9F3020000250003C229@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

When I was investigating this report:

http://archives.postgresql.org/pgsql-bugs/2011-03/msg00349.php

besides providing a straightforward fix here:

http://archives.postgresql.org/pgsql-bugs/2011-03/msg00352.php

I noted that there was nearby code which needed review, as it didn't
seem safe when in a subtransaction. Further review confirmed this
and didn't turn up any other problems in that section of code. So,
a fix for this overreaching optimization is attached. Note that it
is a one-line fix except for some additional comments to explain the
limitation.

This patch is in addition to and orthogonal to the first patch cited
above.

I will add this one to the 9.1 open items list.

-Kevin

Attachment Content-Type Size
ssi-subtransaction-no-optimization.patch text/plain 1.6 KB
From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <pgsql-hackers(at)postgresql(dot)org>, "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: "Dan Ports" <drkp(at)csail(dot)mit(dot)edu>
Subject: Re: Disable optimization when in subtransaction
Date: 2011-04-04 18:57:46
Message-ID: 4D99CE5A020000250003C235@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> When I was investigating this report:
>
> http://archives.postgresql.org/pgsql-bugs/2011-03/msg00349.php
>
> besides providing a straightforward fix here:
>
> http://archives.postgresql.org/pgsql-bugs/2011-03/msg00352.php
>
> I noted that there was nearby code which needed review, as it
> didn't seem safe when in a subtransaction. Further review
> confirmed this and didn't turn up any other problems in that
> section of code. So, a fix for this overreaching optimization is
> attached. Note that it is a one-line fix except for some
> additional comments to explain the limitation.
>
> This patch is in addition to and orthogonal to the first patch
> cited above.
>
> I will add this one to the 9.1 open items list.

I managed to get a one-line patch wrong. Sorry. 2nd try.

-Kevin

Attachment Content-Type Size
ssi-subtransaction-no-optimization-v2.patch text/plain 1.6 KB