| Lists: | pgsql-docs |
|---|
| From: | Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com> |
|---|---|
| To: | pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
| Subject: | Patch for some typos in pgarchivecleanup.sgml |
| Date: | 2010-08-11 05:25:36 |
| Message-ID: | 4C623450.7070107@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
Hi all,
I found some typos in pgarchivecleanup.sgml.
A patch to fix them is attached in this mail.
Please take a look.
Regards,
--
NAGAYASU Satoshi <satoshi(dot)nagayasu(at)gmail(dot)com>
| Attachment | Content-Type | Size |
|---|---|---|
| pgarchivecleanup.sgml.cvs.patch | text/plain | 822 bytes |
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com> |
| Cc: | pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
| Subject: | Re: Patch for some typos in pgarchivecleanup.sgml |
| Date: | 2010-08-11 08:26:42 |
| Message-ID: | AANLkTimd2QSzk42uU=FWTF38wKv539WXQ+bUKAqwHswz@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
2010/8/11 Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com>:
> I found some typos in pgarchivecleanup.sgml.
> A patch to fix them is attached in this mail.
> Please take a look.
-archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
+archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'
This is not a typo. Triple dots ... is used as replaceable part of the path,
and is used also elsewhere. Though I agree that's somewhat confusing.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com>, pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
| Subject: | Re: Patch for some typos in pgarchivecleanup.sgml |
| Date: | 2010-08-15 20:23:03 |
| Message-ID: | 4525.1281903783@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-docs |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> 2010/8/11 Satoshi Nagayasu <satoshi(dot)nagayasu(at)gmail(dot)com>:
>> -archive_cleanup_command = 'pg_archivecleanup -d .../archive %r 2>>cleanup.log'
>> +archive_cleanup_command = 'pg_archivecleanup -d ../archive %r 2>>cleanup.log'
> This is not a typo. Triple dots ... is used as replaceable part of the path,
> and is used also elsewhere. Though I agree that's somewhat confusing.
It seems unnecessary to use that convention here, though. I changed it
to read "/mnt/standby/archive", which is consistent with some other
examples in which an NFS mount is assumed.
The standby.log -> cleanup.log change is an obvious typo, in any case.
regards, tom lane