Misplaced pg_upgrade_support.so ?

Lists: pgsql-testers
From: Glen Barber <glen(dot)j(dot)barber(at)gmail(dot)com>
To: pgsql-testers(at)postgresql(dot)org
Subject: Misplaced pg_upgrade_support.so ?
Date: 2010-06-07 15:26:40
Message-ID: 4C0D0FB0.3020204@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-testers

Hi,

First off, thank you for bringing this into contrib.

I built beta2 this morning to give pg_upgrade a test run, and everything
worked out great. The only thing I am not sure of is the expected
location of pg_upgrade_support.so. It is a default build with the
exception of "--prefix=/usr/local/pgsql-beta2"; pg_upgrade_support.so
ended up in /usr/local/pgsql-beta2/lib.

Here is what I saw when running pg_upgrade initially:

%pg_upgrade -d /var/db/pgsql/data \
-D /var/db/pgsql/data2 \
-b /usr/local/pgsql-beta1/bin \
-B /usr/local/pgsql-beta2/bin
Performing Consistency Checks
-----------------------------
Checking old data directory (/var/db/pgsql/data) ok
Checking new data directory (/var/db/pgsql/data2) ok

pg_upgrade_support.so must be created and installed in \
/usr/local/pgsql-beta2/lib/postgresql/pg_upgrade_support.so

Is this module ending up in the wrong location on install, or is
pg_upgrade looking in the wrong place?

Thanks and regards,

--
Glen Barber


From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Glen Barber <glen(dot)j(dot)barber(at)gmail(dot)com>
Cc: pgsql-testers(at)postgresql(dot)org
Subject: Re: Misplaced pg_upgrade_support.so ?
Date: 2010-06-07 18:43:38
Message-ID: 4C0D3DDA.50909@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-testers


> Is this module ending up in the wrong location on install, or is
> pg_upgrade looking in the wrong place?

Added to Open Items page for 9.0. Bruce says he should get to checking
it sometime tonight or tommorrow. Thanks for bug report.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com


From: Glen Barber <glen(dot)j(dot)barber(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: pgsql-testers(at)postgresql(dot)org
Subject: Re: Misplaced pg_upgrade_support.so ?
Date: 2010-06-07 18:48:05
Message-ID: 4C0D3EE5.9070709@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-testers

On 6/7/10 2:43 PM, Josh Berkus wrote:
>
>> Is this module ending up in the wrong location on install, or is
>> pg_upgrade looking in the wrong place?
>
> Added to Open Items page for 9.0. Bruce says he should get to checking
> it sometime tonight or tommorrow. Thanks for bug report.
>

Excellent, thanks!

--
Glen Barber


From: Glen Barber <glen(dot)j(dot)barber(at)gmail(dot)com>
To: pgsql-testers(at)postgresql(dot)org
Cc: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Subject: Re: Misplaced pg_upgrade_support.so ?
Date: 2010-06-09 12:39:36
Message-ID: 4C0F8B88.3000708@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-testers

On 6/7/10 2:48 PM, Glen Barber wrote:
> On 6/7/10 2:43 PM, Josh Berkus wrote:
>>
>>> Is this module ending up in the wrong location on install, or is
>>> pg_upgrade looking in the wrong place?
>>
>> Added to Open Items page for 9.0. Bruce says he should get to checking
>> it sometime tonight or tommorrow. Thanks for bug report.
>>
>
> Excellent, thanks!
>

Just to follow up, Bruce did take a look at this on -general. In short,
it turns out to be operator error - I never cleaned the source
directories, which caused the extra '/postgresql/' directory in the
hierarchy.

The relevant thread is here:

http://archives.postgresql.org/pgsql-general/2010-06/msg00321.php

Thanks to Bruce and Takahiro Itagaki for taking a look.

Regards,

--
Glen Barber