Missing RULEs from VIEWs and their format

Hi developers!

I have just filed ticket #167 concerning missing RULEs with VIEWs.
On a related but less important note: the formatting of rules might be
improved if was done like triggers are:

-- status quo
CREATE OR REPLACE RULE on_delete AS
ON DELETE TO test DO INSTEAD DELETE FROM test2
WHERE test2.id = old.id;

-- proposal
CREATE OR REPLACE RULE on_delete AS
ON DELETE
TO test
DO INSTEAD
DELETE FROM test2
WHERE test2.id = old.id;

Regards
Erwin

Le 07/04/2010 19:47, Erwin Brandstetter a écrit :
> [...]
> I have just filed ticket #167 concerning missing RULEs with VIEWs.
> On a related but less important note: the formatting of rules might be
> improved if was done like triggers are:
>
> -- status quo
> CREATE OR REPLACE RULE on_delete AS
> ON DELETE TO test DO INSTEAD DELETE FROM test2
> WHERE test2.id = old.id;
>
> -- proposal
> CREATE OR REPLACE RULE on_delete AS
> ON DELETE
> TO test
> DO INSTEAD
> DELETE FROM test2
> WHERE test2.id = old.id;
>

Hummm, /me feels ashamed but happy to see you came back with so many bug
reports and feature requests :)

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

On 08.04.2010 22:38, guillaume(at)lelarge(dot)info wrote:
> Le 07/04/2010 19:47, Erwin Brandstetter a écrit :
>
>> [...]
>> I have just filed ticket #167 concerning missing RULEs with VIEWs.
>> On a related but less important note: the formatting of rules might be
>> improved if was done like triggers are:
>>
>> -- status quo
>> CREATE OR REPLACE RULE on_delete AS
>> ON DELETE TO test DO INSTEAD DELETE FROM test2
>> WHERE test2.id = old.id;
>>
>> -- proposal
>> CREATE OR REPLACE RULE on_delete AS
>> ON DELETE
>> TO test
>> DO INSTEAD
>> DELETE FROM test2
>> WHERE test2.id = old.id;
>>
>>
> Hummm, /me feels ashamed but happy to see you came back with so many bug
> reports and feature requests :)
>

Hey, Guillaume, I have made notes over the last couple of months, but
never got around to report - for all the work piling on my desktop.
And I do try to verify my findings before reporting. Wouldn't be much
help, if I provided noise instead of insight, right?
So, the accumulation of reports is much rather a sign of bad timing on
my side than of quality issues.

Regards
Erwin

Le 09/04/2010 15:03, Erwin Brandstetter a écrit :
> On 08.04.2010 22:38, guillaume(at)lelarge(dot)info wrote:
>> Le 07/04/2010 19:47, Erwin Brandstetter a écrit :
>>
>>> [...]
>>> I have just filed ticket #167 concerning missing RULEs with VIEWs.
>>> On a related but less important note: the formatting of rules might be
>>> improved if was done like triggers are:
>>>
>>> -- status quo
>>> CREATE OR REPLACE RULE on_delete AS
>>> ON DELETE TO test DO INSTEAD DELETE FROM test2
>>> WHERE test2.id = old.id;
>>>
>>> -- proposal
>>> CREATE OR REPLACE RULE on_delete AS
>>> ON DELETE
>>> TO test
>>> DO INSTEAD
>>> DELETE FROM test2
>>> WHERE test2.id = old.id;
>>>
>>>
>> Hummm, /me feels ashamed but happy to see you came back with so many bug
>> reports and feature requests :)
>>
>
> Hey, Guillaume, I have made notes over the last couple of months, but
> never got around to report - for all the work piling on my desktop.

Oh, great.

> And I do try to verify my findings before reporting. Wouldn't be much
> help, if I provided noise instead of insight, right?

Right :)

> So, the accumulation of reports is much rather a sign of bad timing on
> my side than of quality issues.
>

No problem.

Anyways, this is fixed. Thanks for your report.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com