| Lists: | pgsql-hackerspgsql-testers |
|---|
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | pgsql-testers(at)postgresql(dot)org |
| Subject: | Conditional trigger missing from pg_dump |
| Date: | 2010-03-25 17:41:34 |
| Message-ID: | 4BABA04E.6010603@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-testers |
All,
It looks like pg_dump was never modified to include conditional
triggers. If you look in pg_dump.c, there's no provision to dump the
FOR UPDATE OF part of the trigger declaration.
This was discovered by Dave Olszewski while testing conditional triggers.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-testers(at)postgresql(dot)org |
| Subject: | Re: Conditional trigger missing from pg_dump |
| Date: | 2010-03-25 17:45:24 |
| Message-ID: | 21052.1269539124@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-testers |
Josh Berkus <josh(at)agliodbs(dot)com> writes:
> It looks like pg_dump was never modified to include conditional
> triggers. If you look in pg_dump.c, there's no provision to dump the
> FOR UPDATE OF part of the trigger declaration.
That proves nothing; it could be relying on server-side code to produce
the declaration.
> This was discovered by Dave Olszewski while testing conditional triggers.
Please show a specific example of what you're worried about.
regards, tom lane
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Conditional trigger missing from pg_dump |
| Date: | 2010-03-25 18:13:40 |
| Message-ID: | 4BABA7D4.70000@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-testers |
>> This was discovered by Dave Olszewski while testing conditional triggers.
>
> Please show a specific example of what you're worried about.
I'll get you a reproduceable test case later today. In our testing, the
conditional part of the trigger was not being dumped.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com