Re: BUG #5355: locale incorrectly comma-separates "(null)"

The following bug has been logged online:

Bug reference: 5355
Logged by: Andy Lester
Email address: andy(at)petdance(dot)com
PostgreSQL version: 8.3.6
Operating system: Linux
Description: locale incorrectly comma-separates "(null)"
Details:

In my .psqlrc I have the following (among others)

\pset null '(null)'
\pset numericlocale on

When I select numeric columns that have NULL values, they show as "(nu,ll)".

Andy Lester wrote:
> The following bug has been logged online:
>
> Bug reference: 5355
> Logged by: Andy Lester
> Email address: andy(at)petdance(dot)com
> PostgreSQL version: 8.3.6
> Operating system: Linux
> Description: locale incorrectly comma-separates "(null)"
> Details:
>
> In my .psqlrc I have the following (among others)
>
> \pset null '(null)'
> \pset numericlocale on
>
> When I select numeric columns that have NULL values, they show as "(nu,ll)".

Hmm, some of the other formats seem to handle numericlocale even worse :-( :

postgres=# \pset numericlocale on
Showing locale-adjusted numeric output.
postgres=# \pset format latex
Output format is latex.
postgres=# SELECT 1234::numeric, 'foobar' ;
\begin{tabular}{r | l}
\textit{numeric} & \textit{?column?} \\
\hline
1,234 & foo,bar \\
\end{tabular}

\noindent (1 row) \\

(note how 'foobar' got a comma in the middle.)

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

Heikki Linnakangas wrote:
> Andy Lester wrote:
>> The following bug has been logged online:
>>
>> Bug reference: 5355
>> Logged by: Andy Lester
>> Email address: andy(at)petdance(dot)com
>> PostgreSQL version: 8.3.6
>> Operating system: Linux
>> Description: locale incorrectly comma-separates "(null)"
>> Details:
>>
>> In my .psqlrc I have the following (among others)
>>
>> \pset null '(null)'
>> \pset numericlocale on
>>
>> When I select numeric columns that have NULL values, they show as "(nu,ll)".
>
> Hmm, some of the other formats seem to handle numericlocale even worse :-( :
>
> postgres=# \pset numericlocale on
> Showing locale-adjusted numeric output.
> postgres=# \pset format latex
> Output format is latex.
> postgres=# SELECT 1234::numeric, 'foobar' ;
> \begin{tabular}{r | l}
> \textit{numeric} & \textit{?column?} \\
> \hline
> 1,234 & foo,bar \\
> \end{tabular}
>
> \noindent (1 row) \\
>
> (note how 'foobar' got a comma in the middle.)

Ok, here's a patch to fix both of those bugs. It moves the
responsibility of applying numeric locale up from the print_* functions
to the same place where the null string is applied. Less room for bugs
of omission like the latex format bug that way, and it's no longer
applied to the null string. This also makes the print_* code simpler.

I'll port this to back-branches and commit. Thanks for the report!

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com