| Lists: | pgsql-hackers |
|---|
| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | <pgsql-hackers(at)postgresql(dot)org>,<m_lists(at)yahoo(dot)it> |
| Subject: | Re: Review: Patch: Allow substring/replace() to get/set bit values |
| Date: | 2010-01-20 12:45:17 |
| Message-ID: | 4B56A67D020000250002E7EE@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Leonardo F wrote:
> New version of the patch, let me know if I can fix/change something
> else.
All issues addressed, with one tiny nit-pick -- the get_bit and
set_bit methods are not part of the SQL standard. I took the liberty
of removing "SQL-standard" from the documentation of these functions
so that I can mark this "Ready for Committer".
Thanks for the patch!
-Kevin
| Attachment | Content-Type | Size |
|---|---|---|
| getsetbit.patch | application/octet-stream | 12.6 KB |
| From: | Leonardo F <m_lists(at)yahoo(dot)it> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Review: Patch: Allow substring/replace() to get/set bit values |
| Date: | 2010-01-20 13:00:46 |
| Message-ID: | 160331.22704.qm@web29005.mail.ird.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> All issues addressed, with one tiny nit-pick -- the get_bit and
> set_bit methods are not part of the SQL standard.
Damn! I completely forgot to mention that I had no idea if what I wrote
in the docs made any sense...
Well thank you for your thorough review.
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, m_lists(at)yahoo(dot)it |
| Subject: | Re: Review: Patch: Allow substring/replace() to get/set bit values |
| Date: | 2010-01-25 21:00:39 |
| Message-ID: | 7472.1264453239@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Leonardo F wrote:
>> New version of the patch, let me know if I can fix/change something
>> else.
> All issues addressed, with one tiny nit-pick -- the get_bit and
> set_bit methods are not part of the SQL standard. I took the liberty
> of removing "SQL-standard" from the documentation of these functions
> so that I can mark this "Ready for Committer".
Applied with some further editorialization. When I looked at how
OVERLAY(text) was implemented, I didn't like it at all, so I took the
liberty of transforming it to C code and then duplicating that
implementation for bit and bytea. I doubt this would make any
performance difference in simple cases, but it will have less surprise
factor.
regards, tom lane