Empty dictionary file when creating text search dictionary

Lists: pgsql-hackers
From: Robert Gravsjö <robert(at)blogg(dot)se>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Empty dictionary file when creating text search dictionary
Date: 2009-11-30 15:57:18
Message-ID: 4B13EB5E.2070507@blogg.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Found this a couple of weeks back and just re-tested against head:

CREATE TEXT SEARCH DICTIONARY with an empty thesaurus file will crasch
the backend.

To reproduce:
$ echo "" > $(pg_config --sharedir)/tsearch_data/thesaurus_empty.ths

Then use this thesaurus to create a text search dictionary:
CREATE TEXT SEARCH DICTIONARY thesaurus_astro (
TEMPLATE = thesaurus,
DictFile = thesaurus_empty,
Dictionary = english_stem
);

It doesn't matter if the file is compleatly empty or just have comments.
The result is the same.
Add a word:
$ echo "foo: bar" >> $(pg_config
--sharedir)/tsearch_data/thesaurus_empty.ths

Creating the dictionary will now work.

Sorry I have no patch to attach.

Regards,
roppert

PS. I happend to send this mail from a wrong, non-subscribed, address
earlier so if it turns up duplicated I apologize.


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Gravsjö <robert(at)blogg(dot)se>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Empty dictionary file when creating text search dictionary
Date: 2009-11-30 16:39:18
Message-ID: 5596.1259599158@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

=?ISO-8859-1?Q?Robert_Gravsj=F6?= <robert(at)blogg(dot)se> writes:
> Found this a couple of weeks back and just re-tested against head:
> CREATE TEXT SEARCH DICTIONARY with an empty thesaurus file will crasch
> the backend.

Fixed, thanks for the report!

regards, tom lane