Re: [pgadmin-support] pgAdmin3 Version 1.10.0 : Crash when configuring an pgAgent job

Lists: pgadmin-hackerspgadmin-support
From: Rainer Bauer <usenet(at)munnin(dot)com>
To: pgadmin-support(at)postgresql(dot)org
Subject: pgAdmin3 Version 1.10.0 : Crash when configuring an pgAgent job
Date: 2009-07-17 09:56:43
Message-ID: 12710670447.20090717115643@munnin.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers pgadmin-support

Hello,

Here is my setup:

* WinXPSP3
* PostgreSQL 8.4.0: postgresql-8.4.0-1-windows.exe
* pgAgent: pgAgent-3.0.0-win32.zip
I have copied the exe and dll to the pg8.4 binary directory.
* pgAgent.sql was executed in database postgres
* pgAgent service is installed

Steps to reproduce the bug:

1) Select "New job" from the "Jobs" tree element context menu.
(NOTE: The elipses are missing in the command text)
2) Enter a name for the job and close the dialog with OK.
3) Select command "Properties" from the context menu of the newly
created job.
4) Activate the schedules tab and press "Add".
5) Close the schedule dialog using "Cancel".
6) BOOOOOMMMM [1]

Note: The same happens if I try to add a step and the "Step
Definition" dialog is closed.

Rainer

[1] An unhandled exception occured in pgAdmin3.exe [3704]

After attaching VS2005 to the process, I get:

Unhandled exception at 0x0049af2d in pgAdmin3.exe: 0xC0000005: Access violation reading location 0x0000009b.

Stacktrace (NOTE: why is pgAdmin3.pdb missing from the installation?)

pgAdmin3.exe!0049af2d()
[Frames below may be incorrect and/or missing, no symbols loaded for pgAdmin3.exe]
pgAdmin3.exe!00425596()
pgAdmin3.exe!00418d51()
pgAdmin3.exe!00a15cdf()
pgAdmin3.exe!006f6b2d()
pgAdmin3.exe!006e4e43()
pgAdmin3.exe!006e542a()
pgAdmin3.exe!006e54bc()
pgAdmin3.exe!0076be3f()
pgAdmin3.exe!006e54dd()
pgAdmin3.exe!0076be3f()
pgAdmin3.exe!006e54dd()
pgAdmin3.exe!0076be3f()
pgAdmin3.exe!006e54dd()
pgAdmin3.exe!0079e9a2()
pgAdmin3.exe!0079ea0e()
pgAdmin3.exe!007796c0()
pgAdmin3.exe!0077d53d()
ntdll.dll!7c910323()
ntdll.dll!7c910323()
ntdll.dll!7c910385()
ntdll.dll!7c912244()
ntdll.dll!7c910323()
ntdll.dll!7c910385()
ntdll.dll!7c912465()
ntdll.dll!7c9124a9()
ntdll.dll!7c910323()
gdi32.dll!77f17f6c()
gdi32.dll!77f18450()
gdi32.dll!77f18d93()
gdi32.dll!77f18d9d()
gdi32.dll!77f18d9d()
ntdll.dll!7c912427()
ntdll.dll!7c91279f()
ntdll.dll!7c9127bd()
kernel32.dll!7c80a07e()
kernel32.dll!7c80a095()
user32.dll!7e427aa8()
kernel32.dll!7c80a095()
user32.dll!7e41c105()
user32.dll!7e427aa8()
user32.dll!7e41c0b8()
uxtheme.dll!5ad7153d()
uxtheme.dll!5ad73c02()
uxtheme.dll!5ad78b7b()
pgAdmin3.exe!0079f648()
pgAdmin3.exe!0077b71f()
user32.dll!7e418734()
pgAdmin3.exe!0077b71f()
user32.dll!7e418734()
user32.dll!7e418816()
user32.dll!7e41882a()
user32.dll!7e42927b()
user32.dll!7e4292e3()
comctl32.dll!773f7354()
comctl32.dll!773f7436()
comctl32.dll!773f973b()
gdi32.dll!77f1ab0d()
ntdll.dll!7c910a36()
ntdll.dll!7c910981()
ntdll.dll!7c91005d()
ntdll.dll!7c91005d()
user32.dll!7e418734()
user32.dll!7e418816()
user32.dll!7e42a013()
user32.dll!7e42a039()
pgAdmin3.exe!00777c67()
pgAdmin3.exe!0077d900()
ntdll.dll!7c90da2a()
kernel32.dll!7c8024c7()
msctf.dll!7475577a()
msctf.dll!74755f00()
msctf.dll!7473f87f()
MIPro.dll!64001280()
user32.dll!7e418b26()
kernel32.dll!7c80262a()
kernel32.dll!7c80262a()
ntdll.dll!7c90da2a()
user32.dll!7e431923()
user32.dll!7e42b317()
user32.dll!7e42b326()
user32.dll!7e42b326()
user32.dll!7e4316c8()
user32.dll!7e4316d8()
ntdll.dll!7c90e473()
user32.dll!7e4318d1()
user32.dll!7e43e1ad()
user32.dll!7e43e18a()
msctf.dll!74730f0a()
msctf.dll!74730f0f()
user32.dll!7e42b401()
msctf.dll!747313d4()
uxtheme.dll!5ad7153d()
uxtheme.dll!5ad73c02()
uxtheme.dll!5ad78b7b()
pgAdmin3.exe!0079f648()
pgAdmin3.exe!0077b71f()
user32.dll!7e418734()
user32.dll!7e418816()
user32.dll!7e42b326()
user32.dll!7e4189cd()
user32.dll!7e431b7c()
user32.dll!7e418a10()
user32.dll!7e4274ff()
pgAdmin3.exe!0077b62a()
pgAdmin3.exe!007af925()
pgAdmin3.exe!007e2b1d()
pgAdmin3.exe!007e265d()
pgAdmin3.exe!007e29d8()
pgAdmin3.exe!007e2cf1()
pgAdmin3.exe!007db762()
pgAdmin3.exe!007361ac()
pgAdmin3.exe!00724ed5()
pgAdmin3.exe!007dc177()
pgAdmin3.exe!006c9f09()
pgAdmin3.exe!0094bb8a()
kernel32.dll!7c817077()
pgAdmin3.exe!00750074()
pgAdmin3.exe!00630072()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!00630072()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!00630072()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!00630072()
pgAdmin3.exe!0067006e()
pgAdmin3.exe!0067006e()


From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Rainer Bauer <usenet(at)munnin(dot)com>
Cc: pgadmin-support(at)postgresql(dot)org, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: [pgadmin-support] pgAdmin3 Version 1.10.0 : Crash when configuring an pgAgent job
Date: 2009-07-17 11:30:43
Message-ID: 4A6060E3.4090109@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers pgadmin-support

[Adding pgadmin-hackers..]

Hi Rainer,

I am able to reproduce the same on Ubuntu 9.04 (32 bit).
Thanks for reporting this.

Hi Dave/Guillaume,

Please find the patch for the same.
Schedule dialog does not have SQL pane.
And, we're try to check the Read-Only check-box over there. :(

Rainer Bauer wrote:
> Hello,
>
> Here is my setup:
>
> * WinXPSP3
> * PostgreSQL 8.4.0: postgresql-8.4.0-1-windows.exe
> * pgAgent: pgAgent-3.0.0-win32.zip
> I have copied the exe and dll to the pg8.4 binary directory.
> * pgAgent.sql was executed in database postgres
> * pgAgent service is installed
>
> Steps to reproduce the bug:
>
> 1) Select "New job" from the "Jobs" tree element context menu.
> (NOTE: The elipses are missing in the command text)
> 2) Enter a name for the job and close the dialog with OK.
> 3) Select command "Properties" from the context menu of the newly
> created job.
> 4) Activate the schedules tab and press "Add".
> 5) Close the schedule dialog using "Cancel".
> 6) BOOOOOMMMM [1]
>
> Note: The same happens if I try to add a step and the "Step
> Definition" dialog is closed.
>
> Rainer
>
>
> [1] An unhandled exception occured in pgAdmin3.exe [3704]
>
> After attaching VS2005 to the process, I get:
>
> Unhandled exception at 0x0049af2d in pgAdmin3.exe: 0xC0000005: Access violation reading location 0x0000009b.
>
> Stacktrace (NOTE: why is pgAdmin3.pdb missing from the installation?)

--
Thanks & Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com

Attachment Content-Type Size
SegFaultSetNewScheduleForJob_v1.patch text/x-diff 306 bytes

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Rainer Bauer <usenet(at)munnin(dot)com>, pgadmin-support(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Re: [pgadmin-support] pgAdmin3 Version 1.10.0 : Crash when configuring an pgAgent job
Date: 2009-07-19 21:42:50
Message-ID: 200907192342.50920.guillaume@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers pgadmin-support

Hi Ashesh and Rainer,

Le vendredi 17 juillet 2009 à 13:30:43, Ashesh Vashi a écrit :
> [Adding pgadmin-hackers..]
>
> Hi Rainer,
>
> I am able to reproduce the same on Ubuntu 9.04 (32 bit).
> Thanks for reporting this.
>
> Hi Dave/Guillaume,
>
> Please find the patch for the same.
> Schedule dialog does not have SQL pane.
> And, we're try to check the Read-Only check-box over there. :(
>

Yeah, you found the issue. There was another one on the dlgStep dialog. Only
dlgJob need this. I changed your patch to fix the two issues. You'll find it
attached for reference. I've commited this patch on the 1.10 branch and on the
trunk.

Thanks a lot.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
ashesh.patch text/x-patch 1.1 KB

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Rainer Bauer <usenet(at)munnin(dot)com>, pgadmin-support(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: Re: [pgadmin-support] pgAdmin3 Version 1.10.0 : Crash when configuring an pgAgent job
Date: 2009-07-21 08:20:30
Message-ID: 200907211020.31083.guillaume@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers pgadmin-support

Le dimanche 19 juillet 2009 à 23:42:50, Guillaume Lelarge a écrit :
> Hi Ashesh and Rainer,
>
> Le vendredi 17 juillet 2009 à 13:30:43, Ashesh Vashi a écrit :
> > [Adding pgadmin-hackers..]
> >
> > Hi Rainer,
> >
> > I am able to reproduce the same on Ubuntu 9.04 (32 bit).
> > Thanks for reporting this.
> >
> > Hi Dave/Guillaume,
> >
> > Please find the patch for the same.
> > Schedule dialog does not have SQL pane.
> > And, we're try to check the Read-Only check-box over there. :(
>
> Yeah, you found the issue. There was another one on the dlgStep dialog.
> Only dlgJob need this. I changed your patch to fix the two issues. You'll
> find it attached for reference. I've commited this patch on the 1.10 branch
> and on the trunk.
>

Hmmm. I should better think before applying a patch. The previous one does not
fix every issues. dlgStep can be displayed alone (in which case it does have a
SQL pane) and from the dlgJob dialog (in which case it doesn't). The same for
dlgSchedule. This new patch takes care of this.

Sorry about all this.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
agent_v1.patch text/x-patch 1.3 KB