ECPG dynamic cursor, SQLDA support

Hi,

attached is our latest patch extending ECPG:

1. Support computed cursorname (DECLARE :cursorname ..., etc)
No change in that part, it's purely a parser-only change, there's no
ECPGdo() change you criticized or any other bad juju. Because of
adding support for :cursorname and the dynamically generated
ECPG grammar, we needed to modify the main gram.y as well,
to make way for computed cursor names. The fetch_direction and
FetchStmt change was needed in gram.y because otherwise
"FETCH fetch_direction from_in cursor_name" and
"MOVE fetch_direction from_in cursor_name" rules caused
shift/reduce conflicts in the "fetch_direction" rule in ECPG grammar.
This modification was a little sacrifice in gram.y but it allowed
keeping the ECPG grammar clean and little change in the automatic
grammar generation.

2. Support SQLDA structure in ECPG, both in USING DESCRIPTOR
and INTO DESCRIPTOR, if Informix-compatible mode is set.
This means the following changes
- introduce the pg_sqlda_t and pg_sqlvar_t structures, ECPGt_sqlda type
and SQLNNN contants in sqltypes.h
- make a distinction between DESCRIPTOR and SQL DESCRIPTOR
in Informix mode
- Support FETCH ... USING DESCRIPTOR in Informix mode only,
that works the same way as FETCH ... INTO DESCRIPTOR.
3. Support DESCRIBE OUTPUT
The support was added as a new, exported ECPGdescribe2() function
in descriptor.c, the old unsupported ECPGescribe() interface was
left intact
so the libecpg.so major library version doesn't need to be changed.

Best regards,
Zoltán Böszörményi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/

On Wed, Jun 24, 2009 at 11:51:57AM +0200, Boszormenyi Zoltan wrote:
> attached is our latest patch extending ECPG:

Just as a short explanation, the older versions were sent to me only and I
reviewed them. I haven't found time to to review this one yet though.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!

On Thu, Jun 25, 2009 at 11:18 AM, Michael Meskes<meskes(at)postgresql(dot)org> wrote:
> On Wed, Jun 24, 2009 at 11:51:57AM +0200, Boszormenyi Zoltan wrote:
>> attached is our latest patch extending ECPG:
>
> Just as a short explanation, the older versions were sent to me only and I
> reviewed them. I haven't found time to to review this one yet though.

Are you planning to review this one soon?

...Robert

On Wed, Jun 24, 2009 at 4:51 AM, Boszormenyi Zoltan<zb(at)cybertec(dot)at> wrote:
> Hi,
>
> attached is our latest patch extending ECPG:
>

haven't tested this nor reviewed the code in detail, just some little questions:

1) This is in /src/interfaces/ecpg/ecpglib/sqlda.c, and doesn't seems
something we want in our files... looking at actual code seems like
ecpg.c have something similar but at least specify that it has the
same license as PostgreSQL

+ *
+ * (C) 2009 Cybertec GmbH
+ * Zoltán Böszörményi <zb(at)cybertec(dot)at>
+ * Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
+ */

2) In src/interfaces/ecpg/include/sqltypes.h there some #if 0 added,
why are those? seems like something that doesn't need to be added

+ #if 0
+ #define SQLSET 19
+ #define SQLMULTISET 20
+ #define SQLLIST 21
+ #define SQLROW 22
+ #define SQLCOLLECTION 23
+ #define SQLROWREF 24
+ #endif

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

On Sat, Jul 25, 2009 at 4:38 PM, Jaime
Casanova<jcasanov(at)systemguards(dot)com(dot)ec> wrote:
> On Wed, Jun 24, 2009 at 4:51 AM, Boszormenyi Zoltan<zb(at)cybertec(dot)at> wrote:
>> Hi,
>>
>> attached is our latest patch extending ECPG:
>>
>
> haven't tested this nor reviewed the code in detail, just some little questions:
>
> 1) This is in /src/interfaces/ecpg/ecpglib/sqlda.c, and doesn't seems
> something we want in our files... looking at actual code seems like
> ecpg.c have something similar but at least specify that it has the
> same license as PostgreSQL
>
> +  *
> +  * (C) 2009 Cybertec GmbH
> +  *     Zoltán Böszörményi <zb(at)cybertec(dot)at>
> +  *     Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
> +  */
>

seems like Michael already comment this but i lose that thread before...

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

On Sat, Jul 25, 2009 at 04:38:25PM -0500, Jaime Casanova wrote:
> 1) This is in /src/interfaces/ecpg/ecpglib/sqlda.c, and doesn't seems
> something we want in our files... looking at actual code seems like
> ecpg.c have something similar but at least specify that it has the
> same license as PostgreSQL

Oops, didn't notice that this still had the old text, fixed in CVS.

> + * (C) 2009 Cybertec GmbH
> + * Zoltán Böszörményi <zb(at)cybertec(dot)at>
> + * Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
> + */

So am I right to assume that the consensus is to not accept this kind of
notice?

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!