Lists: | pgsql-hackers |
---|
From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | cs_CZ vs regression tests, part N |
Date: | 2009-03-18 12:35:55 |
Message-ID: | 8300.1237379755@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
It's still broken:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01
I remain of the opinion that supporting the regression tests in a locale
that works like this is more trouble than it's worth.
regards, tom lane
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N |
Date: | 2009-03-18 15:45:48 |
Message-ID: | 49C1172C.5020100@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Dne 18.03.09 13:35, Tom Lane napsal(a):
> It's still broken:
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01
Yes, it is. But it is PL test now ;-).
> I remain of the opinion that supporting the regression tests in a locale
> that works like this is more trouble than it's worth.
Problem disappear when collation per column will be implemented. Until
it we need to workaround it somehow.
Zdenek
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N |
Date: | 2009-03-20 13:33:20 |
Message-ID: | 49C39B20.7080204@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Tom Lane wrote:
> It's still broken:
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01
>
> I remain of the opinion that supporting the regression tests in a locale
> that works like this is more trouble than it's worth.
We looked into this and it turns out that this is actually a C locale
vs. all-other-locales issue; not specific to Czech. More specifically,
it is related to the sorting of upper-case vs. lower-case letters. A
_1.out file is an appropriate answer here.
(Hmm, no one except Zdenek testing locales yet on the build farm? Can't
easily tell from the index page.)
From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N |
Date: | 2009-03-20 13:44:46 |
Message-ID: | 49C39DCE.6070504@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> Tom Lane wrote:
>> It's still broken:
>> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01
>>
>>
>> I remain of the opinion that supporting the regression tests in a locale
>> that works like this is more trouble than it's worth.
>
> We looked into this and it turns out that this is actually a C locale
> vs. all-other-locales issue; not specific to Czech. More
> specifically, it is related to the sorting of upper-case vs.
> lower-case letters. A _1.out file is an appropriate answer here.
>
> (Hmm, no one except Zdenek testing locales yet on the build farm?
> Can't easily tell from the index page.)
>
Yes, dungbeetle is ... I took tcl out of its config until we had this
sorted out. Are you going to commit a _1.out file?
cheers
andrew
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N |
Date: | 2009-03-20 15:15:56 |
Message-ID: | 1237562156.2806.2.camel@localhost |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Peter Eisentraut píše v pá 20. 03. 2009 v 15:33 +0200:
> (Hmm, no one except Zdenek testing locales yet on the build farm? Can't
> easily tell from the index page.)
It seems to me like good idea to add column with locale list tested on a
animal.
Zdenek
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N |
Date: | 2009-03-23 08:32:17 |
Message-ID: | 49C74911.6000202@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Andrew Dunstan wrote:
> Yes, dungbeetle is ... I took tcl out of its config until we had this
> sorted out. Are you going to commit a _1.out file?
Done
From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-03-24 07:43:44 |
Message-ID: | 49C88F30.1050205@gmx.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> Andrew Dunstan wrote:
>> Yes, dungbeetle is ... I took tcl out of its config until we had this
>> sorted out. Are you going to commit a _1.out file?
>
> Done
Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01
This time it's the btree_gist and tsearch tests that are complaining,
and this time it is because of the Czech locale rules.
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-03-24 11:23:56 |
Message-ID: | 49C8C2CC.1080405@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Dne 24.03.09 08:43, Peter Eisentraut napsal(a):
> Peter Eisentraut wrote:
>> Andrew Dunstan wrote:
>>> Yes, dungbeetle is ... I took tcl out of its config until we had this
>>> sorted out. Are you going to commit a _1.out file?
>>
>> Done
>
> Can't catch a break:
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01
>
>
> This time it's the btree_gist and tsearch tests that are complaining,
> and this time it is because of the Czech locale rules.
Patch attached. I hope last one.
thanks Zdenek
Attachment | Content-Type | Size |
---|---|---|
contrib.patch.gz | application/x-gzip | 59.3 KB |
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-04-24 04:53:52 |
Message-ID: | 49F145E0.6090507@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Please, can somebody look on this patch? I would like to have green
lights on my buildfarms.
thanks Zdenek
Dne 24.03.09 12:23, Zdenek Kotala napsal(a):
> Dne 24.03.09 08:43, Peter Eisentraut napsal(a):
>> Peter Eisentraut wrote:
>>> Andrew Dunstan wrote:
>>>> Yes, dungbeetle is ... I took tcl out of its config until we had
>>>> this sorted out. Are you going to commit a _1.out file?
>>>
>>> Done
>>
>> Can't catch a break:
>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01
>>
>>
>> This time it's the btree_gist and tsearch tests that are complaining,
>> and this time it is because of the Czech locale rules.
>
> Patch attached. I hope last one.
>
> thanks Zdenek
>
>
> ------------------------------------------------------------------------
>
>
From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-04-24 05:17:27 |
Message-ID: | 49F14B67.4070507@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
This diff in tsearch2.out surprised me:
@@ -2390,7 +2390,7 @@
<body>
<b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
<a href="http://www.google.com/foo.bar.html" target="_blank">YES
</a>
- ff-bg
+ ff-bg
<script>
document.write(15);
</script>
Any idea what's causing that?
Zdenek Kotala wrote:
> Please, can somebody look on this patch? I would like to have green
> lights on my buildfarms.
>
> thanks Zdenek
>
>
>
> Dne 24.03.09 12:23, Zdenek Kotala napsal(a):
>> Dne 24.03.09 08:43, Peter Eisentraut napsal(a):
>>> Peter Eisentraut wrote:
>>>> Andrew Dunstan wrote:
>>>>> Yes, dungbeetle is ... I took tcl out of its config until we had
>>>>> this sorted out. Are you going to commit a _1.out file?
>>>>
>>>> Done
>>>
>>> Can't catch a break:
>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01
>>>
>>>
>>> This time it's the btree_gist and tsearch tests that are complaining,
>>> and this time it is because of the Czech locale rules.
>>
>> Patch attached. I hope last one.
>>
>> thanks Zdenek
>>
>>
>> ------------------------------------------------------------------------
>>
>>
>
>
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-04-24 05:48:18 |
Message-ID: | 49F152A2.1040003@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):
> This diff in tsearch2.out surprised me:
>
> @@ -2390,7 +2390,7 @@
> <body>
> <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
> <a href="http://www.google.com/foo.bar.html" target="_blank">YES
> </a>
> - ff-bg
> + ff-bg
> <script>
> document.write(15);
> </script>
>
> Any idea what's causing that?
Good catch. I don't see it on
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2009-04-24%2004:47:44
I'm playing with it now. Unfortunately I don't have my laptop with
workspace now.
Thanks Zdenek
>
>
> Zdenek Kotala wrote:
>> Please, can somebody look on this patch? I would like to have green
>> lights on my buildfarms.
>>
>> thanks Zdenek
>>
>>
>>
>> Dne 24.03.09 12:23, Zdenek Kotala napsal(a):
>>> Dne 24.03.09 08:43, Peter Eisentraut napsal(a):
>>>> Peter Eisentraut wrote:
>>>>> Andrew Dunstan wrote:
>>>>>> Yes, dungbeetle is ... I took tcl out of its config until we had
>>>>>> this sorted out. Are you going to commit a _1.out file?
>>>>>
>>>>> Done
>>>>
>>>> Can't catch a break:
>>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01
>>>>
>>>>
>>>> This time it's the btree_gist and tsearch tests that are
>>>> complaining, and this time it is because of the Czech locale rules.
>>>
>>> Patch attached. I hope last one.
>>>
>>> thanks Zdenek
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>
>>
>
>
From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-04-24 07:29:30 |
Message-ID: | 49F16A5A.208@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):
> This diff in tsearch2.out surprised me:
>
> @@ -2390,7 +2390,7 @@
> <body>
> <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
> <a href="http://www.google.com/foo.bar.html" target="_blank">YES
> </a>
> - ff-bg
> + ff-bg
> <script>
> document.write(15);
> </script>
>
> Any idea what's causing that?
Hmm. I don't understand it. I'm not able to generate this again nad I
don't have idea why it happend. It is definitely wrong. Shell I sent you
new diff or do you fix it yourself?
Thanks Zdenek
From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: cs_CZ vs regression tests, part N+1 |
Date: | 2009-05-08 14:49:02 |
Message-ID: | 4A04465E.1020800@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Zdenek Kotala wrote:
> Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):
>> This diff in tsearch2.out surprised me:
>>
>> @@ -2390,7 +2390,7 @@
>> <body>
>> <b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
>> <a href="http://www.google.com/foo.bar.html" target="_blank">YES
>> </a>
>> - ff-bg
>> + ff-bg
>> <script>
>> document.write(15);
>> </script>
>>
>> Any idea what's causing that?
>
> Hmm. I don't understand it. I'm not able to generate this again nad I
> don't have idea why it happend. It is definitely wrong. Shell I sent you
> new diff or do you fix it yourself?
Committed, without that mystery change.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com