Re: Missing files after make install ?

Lists: pgsql-hackers
From: Olivier Thauvin <nanardon(at)nanardon(dot)zarb(dot)org>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Missing files after make install ?
Date: 2009-02-12 23:05:39
Message-ID: 20090212230531.GC9594@localhost.home.nanardon.zarb.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

I am the packager of postgresql for mandriva, and I receive this bug to
today

https://qa.mandriva.com/show_bug.cgi?id=47722

postgresql8.3-contribe missed some files like uuid-ossp.sql

Description of problem:
uuid-ossp was not found in the .spec file

By take a look in the /contrib/README file, some items are missed
intagg
intarray
spi
start-scripts
xml2 (libxml2 ?)

***

I just check, and trully, files provided in contrib, mainly *.sql, are
not installed during %make install from contrib/ subdirectory.

Is this an error ? a mistake ? If this should be fix, can you provide a
patch quickly (before I release 8.3.6 :) ?

Thanks by advance.


From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Olivier Thauvin <nanardon(at)nanardon(dot)zarb(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Missing files after make install ?
Date: 2009-02-13 01:26:35
Message-ID: 4994CC4B.1090402@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Olivier Thauvin wrote:
> Hi,
>
> I am the packager of postgresql for mandriva, and I receive this bug to
> today
>
> https://qa.mandriva.com/show_bug.cgi?id=47722
>
> postgresql8.3-contribe missed some files like uuid-ossp.sql
>
> Description of problem:
> uuid-ossp was not found in the .spec file
>
> By take a look in the /contrib/README file, some items are missed
> intagg
> intarray
> spi
> start-scripts
> xml2 (libxml2 ?)
>
> ***
>
> I just check, and trully, files provided in contrib, mainly *.sql, are
> not installed during %make install from contrib/ subdirectory.
>
> Is this an error ? a mistake ? If this should be fix, can you provide a
> patch quickly (before I release 8.3.6 :) ?
>
> Thanks by advance.
>

It's up to you to decide what you want packaged, not us. For example, as
a packager, you surely don't want to use our initscript - you should be
using one that is appropriate for your distro. All the other packagers
manage to make these decisions. Maybe you would get some inspiration
from the spec files used by other RPM based distros.

cheers

andrew