| Lists: | pgsql-hackers |
|---|
| From: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Signal handling patch (v2) for Synch Rep |
| Date: | 2008-11-04 12:04:33 |
| Message-ID: | 3f0b79eb0811040404r799d3170v5bb9f201000f1771@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
To be reviewed easily, I'm splitting Synch Rep patch into some pieces.
Attached is a patch of signal handling changes for Synch Rep.
http://archives.postgresql.org/pgsql-hackers/2008-09/msg00950.php
Though I've posted the WIP patch previously, this is a finished one.
Please feel free to comment on it.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| signal_handling_v2.patch | text/x-patch | 14.5 KB |
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: Signal handling patch (v2) for Synch Rep |
| Date: | 2008-11-04 12:19:28 |
| Message-ID: | 1225801168.3971.1075.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, 2008-11-04 at 21:04 +0900, Fujii Masao wrote:
> To be reviewed easily, I'm splitting Synch Rep patch into some pieces.
Great idea. I'll be doing that also.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Signal handling patch (v2) for Synch Rep |
| Date: | 2008-11-14 21:12:08 |
| Message-ID: | 491DE9A8.7020800@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Fujii Masao wrote:
> Attached is a patch of signal handling changes for Synch Rep.
It seems that we wouldn't need to use the BackendPidGetProc function,
nor the new AuxiliaryPidGetProc function, if we stored a PGPROC *
instead of the pid in ProcState.procPid.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From: | "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Signal handling patch (v2) for Synch Rep |
| Date: | 2008-11-16 06:08:04 |
| Message-ID: | 3f0b79eb0811152208t105be391k4cf8f397ef83d4b3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Nov 15, 2008 at 6:12 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Fujii Masao wrote:
>>
>> Attached is a patch of signal handling changes for Synch Rep.
>
> It seems that we wouldn't need to use the BackendPidGetProc function, nor
> the new AuxiliaryPidGetProc function, if we stored a PGPROC * instead of the
> pid in ProcState.procPid.
Sounds good! That can cut back on ProcArrayLock.
And, I add the code which deletes the request from WalSenderShmem
when the backend dies or aborts. I would call the delete function within
AbortTransaction(), and add it as a callback function (on_shmem_exit).
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center