Re: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys

Lists: pgsql-hackers
From: Charlie Savage <cfis(at)savagexi(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys
Date: 2008-11-06 06:30:46
Message-ID: 49128F16.70204@savagexi.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

A couple of months ago I noted that 8.3.4 doesn't compile on Vista using
MingW+msys under certain conditions:

http://archives.postgresql.org/pgsql-hackers/2008-09/msg01496.php

8.3.5 has the same problem.

Attached are two one line patches that fix it.

Thanks,

Charlie

Attachment Content-Type Size
libpq-int-win32.patch text/plain 226 bytes
libpq-be-win32.patch text/plain 244 bytes
From: Charlie Savage <cfis(at)savagexi(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys
Date: 2008-11-06 06:40:41
Message-ID: 49129169.6010001@savagexi.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Charlie Savage wrote:
> A couple of months ago I noted that 8.3.4 doesn't compile on Vista using
> MingW+msys under certain conditions:
>
> http://archives.postgresql.org/pgsql-hackers/2008-09/msg01496.php
>
> 8.3.5 has the same problem.
>
> Attached are two one line patches that fix it.

Sorry, I attached incorrect patches in the original email. Here are the
correct ones.

Thanks,

Charlie
--
Charlie Savage
http://cfis.savagexi.com

Attachment Content-Type Size
libpq-be-win32.patch text/plain 253 bytes
libpq-int-win32.patch text/plain 255 bytes
From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Charlie Savage <cfis(at)savagexi(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys
Date: 2009-01-09 22:53:11
Message-ID: 200901092253.n09MrBZ25272@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Uh, do we still need this patch?

---------------------------------------------------------------------------

Charlie Savage wrote:
> Charlie Savage wrote:
> > A couple of months ago I noted that 8.3.4 doesn't compile on Vista using
> > MingW+msys under certain conditions:
> >
> > http://archives.postgresql.org/pgsql-hackers/2008-09/msg01496.php
> >
> > 8.3.5 has the same problem.
> >
> > Attached are two one line patches that fix it.
>
> Sorry, I attached incorrect patches in the original email. Here are the
> correct ones.
>
> Thanks,
>
> Charlie
> --
> Charlie Savage
> http://cfis.savagexi.com

> *** libpq-be.h.old Wed Nov 5 23:32:50 2008
> --- libpq-be.h Wed Nov 5 23:35:52 2008
> ***************
> *** 47,52 ****
> --- 47,53 ----
>
> #ifdef ENABLE_SSPI
> #define SECURITY_WIN32
> + #include <ntsecapi.h>
> #include <security.h>
> #undef SECURITY_WIN32
>
>
> *** libpq-int.h.old Wed Nov 5 23:37:48 2008
> --- libpq-int.h Wed Nov 5 23:38:14 2008
> ***************
> *** 54,59 ****
> --- 54,60 ----
>
> #ifdef ENABLE_SSPI
> #define SECURITY_WIN32
> + #include <ntsecapi.h>
> #include <security.h>
> #undef SECURITY_WIN32
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

From: Charlie Savage <cfis(at)savagexi(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys
Date: 2009-01-12 07:41:57
Message-ID: 496AF445.7040102@savagexi.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Bruce,

> Uh, do we still need this patch?

I'd say yes for 8.3.x (my guess is that I see this because I have
additional libraries installed on my mingw version versus what other
developers have - perhaps openssl-0.9.8i).

Not sure on 8.4, but can test if you'd like.

Charlie

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Charlie Savage <cfis(at)savagexi(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 2 small patches that fix 8.3.5 compile issues on Vista+MingW+Msys
Date: 2009-01-12 14:16:06
Message-ID: 496B50A6.8080706@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Charlie Savage wrote:
> Hi Bruce,
>
>> Uh, do we still need this patch?
>
> I'd say yes for 8.3.x (my guess is that I see this because I have
> additional libraries installed on my mingw version versus what other
> developers have - perhaps openssl-0.9.8i).
>
> Not sure on 8.4, but can test if you'd like.

Please do.

IIRC I was unable to reproduce it the last time, but that could very
well be environment-specific.

//Magnus