| Lists: | pgsql-committers |
|---|
| From: | adunstan(at)postgresql(dot)org (Andrew Dunstan) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Disable statement timeouts while making or restoring dumps. |
| Date: | 2008-05-03 23:32:32 |
| Message-ID: | 20080503233232.545767559CC@cvs.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Log Message:
-----------
Disable statement timeouts while making or restoring dumps.
Joshua Drake.
Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_backup_archiver.c (r1.154 -> r1.155)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_archiver.c?r1=1.154&r2=1.155)
pg_dump.c (r1.488 -> r1.489)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.488&r2=1.489)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Disable statement timeouts while making or restoring dumps. |
| Date: | 2008-05-04 00:52:53 |
| Message-ID: | 1686.1209862373@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
adunstan(at)postgresql(dot)org (Andrew Dunstan) writes:
> Disable statement timeouts while making or restoring dumps.
The pg_backup_archiver.c change is wrong: the command should
be issued inside _doSetFixedOutputState().
regards, tom lane
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Disable statement timeouts while making or restoring dumps. |
| Date: | 2008-05-04 03:48:43 |
| Message-ID: | 481D321B.9070103@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Tom Lane wrote:
> adunstan(at)postgresql(dot)org (Andrew Dunstan) writes:
>
>> Disable statement timeouts while making or restoring dumps.
>>
>
> The pg_backup_archiver.c change is wrong: the command should
> be issued inside _doSetFixedOutputState().
>
>
>
Yes, quite true. Sorry. I have fixed it.
cheers
andrew