| Lists: | pgsql-hackers |
|---|
| From: | Greg Sabino Mullane <greg(at)turnstep(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | pg_dump should not try CREATE OR REPLACE LANGUAGE < 9.0 |
| Date: | 2010-05-12 19:38:19 |
| Message-ID: | 20100512193819.GI31028@core.home |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Subject line kind of says it all: LANGUAGE replacement was
introduced in 9.0, but pg_dump is trying it on all versions.
--
Greg Sabino Mullane greg(at)turnstep(dot)com
End Point Corporation
PGP Key: 0x14964AC8 201005121537
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump.create.language.patch | text/plain | 759 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Sabino Mullane <greg(at)turnstep(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_dump should not try CREATE OR REPLACE LANGUAGE < 9.0 |
| Date: | 2010-05-12 20:09:24 |
| Message-ID: | 4765.1273694964@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Greg Sabino Mullane <greg(at)turnstep(dot)com> writes:
> Subject line kind of says it all: LANGUAGE replacement was
> introduced in 9.0, but pg_dump is trying it on all versions.
So? pg_dump output is never promised to load into older server
versions.
The proposed patch is quite wrong anyway, because it is looking at
the source server version, not the (unknowable) target version.
regards, tom lane