| Lists: | pgsql-patches |
|---|
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | pgsql-patches(at)postgreSQL(dot)org |
| Subject: | HOT version 18 |
| Date: | 2007-09-18 02:26:44 |
| Message-ID: | 24154.1190082404@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
I have completed a first review pass over all of the HOT patch, and am
now reasonably satisfied with coding style, APIs, etc. There are still
two or three areas that need discussion, which I'll start a separate
thread for on -hackers. In the meantime, here's some code for people to
test and poke at ...
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| hot-v18.patch.gz | application/octet-stream | 64.2 KB |
| From: | "Jaime Casanova" <systemguards(at)gmail(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: HOT version 18 |
| Date: | 2007-09-18 06:00:42 |
| Message-ID: | c2d9e70e0709172300g7f0506bo81a56a6914e36d72@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On 9/17/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I have completed a first review pass over all of the HOT patch, and am
> now reasonably satisfied with coding style, APIs, etc. There are still
> two or three areas that need discussion, which I'll start a separate
> thread for on -hackers. In the meantime, here's some code for people to
> test and poke at ...
>
> regards, tom lane
>
>
this sql scripts make current cvs + patch to crash with this message
in the logs:
LOG: statement: update test set c2 = c2 -15 where current of q1;
TRAP: FailedAssertion("!(tuple_tableoid == table_oid)", File:
"execCurrent.c", Line: 128)
LOG: server process (PID 27599) was terminated by signal 6: Aborted
LOG: terminating any other active server processes
--
regards,
Jaime Casanova
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook
| Attachment | Content-Type | Size |
|---|---|---|
| test-hot.sql | application/octet-stream | 581 bytes |
| From: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> |
|---|---|
| To: | "Jaime Casanova" <systemguards(at)gmail(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: HOT version 18 |
| Date: | 2007-09-18 06:36:08 |
| Message-ID: | 2e78013d0709172336s2ee122ceqd2bfdb5aad8d824f@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On 9/18/07, Jaime Casanova <systemguards(at)gmail(dot)com> wrote:
>
>
>
> this sql scripts make current cvs + patch to crash with this message
> in the logs:
>
>
Can you please check if the attached patch fixes the issue for you ?
It sets t_tableOid before returning a HOT tuple to the caller.
Thanks,
Pavan
--
Pavan Deolasee
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| HOT-set-tableoid.patch | text/x-patch | 472 bytes |
| From: | Zoltan Boszormenyi <zb(at)cybertec(dot)at> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Jaime Casanova <systemguards(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: HOT version 18 |
| Date: | 2007-09-18 10:20:05 |
| Message-ID: | 46EFA655.2020100@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Hi,
Pavan Deolasee írta:
>
>
> On 9/18/07, *Jaime Casanova* <systemguards(at)gmail(dot)com
> <mailto:systemguards(at)gmail(dot)com>> wrote:
>
>
>
> this sql scripts make current cvs + patch to crash with this message
> in the logs:
>
>
> Can you please check if the attached patch fixes the issue for you ?
> It sets t_tableOid before returning a HOT tuple to the caller.
>
> Thanks,
> Pavan
I can confirm that the script crashed HOT v18 and your patch fixes it.
Best regards,
Zoltán Böszörményi
--
----------------------------------
Zoltán Böszörményi
Cybertec Geschwinde & Schönig GmbH
http://www.postgresql.at/
| From: | "Jaime Casanova" <systemguards(at)gmail(dot)com> |
|---|---|
| To: | "Zoltan Boszormenyi" <zb(at)cybertec(dot)at> |
| Cc: | "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: HOT version 18 |
| Date: | 2007-09-18 12:35:33 |
| Message-ID: | c2d9e70e0709180535r3652d495l27c4f3458c15351a@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On 9/18/07, Zoltan Boszormenyi <zb(at)cybertec(dot)at> wrote:
> Hi,
>
> Pavan Deolasee írta:
> >
> >
> > On 9/18/07, *Jaime Casanova* <systemguards(at)gmail(dot)com
> > <mailto:systemguards(at)gmail(dot)com>> wrote:
> >
> >
> >
> > this sql scripts make current cvs + patch to crash with this message
> > in the logs:
> >
> >
> > Can you please check if the attached patch fixes the issue for you ?
> > It sets t_tableOid before returning a HOT tuple to the caller.
> >
> > Thanks,
> > Pavan
>
> I can confirm that the script crashed HOT v18 and your patch fixes it.
>
yeah! it works fine for me now...
--
regards,
Jaime Casanova
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook