Function quote_literal broken in CATALOG_VERSION_NO 200707251

Lists: pgsql-hackers
From: "Jignesh K(dot) Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Function quote_literal broken in CATALOG_VERSION_NO 200707251
Date: 2007-08-20 19:12:48
Message-ID: 46C9E7B0.5020306@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Just FYI:

I took the latest snapshot CATALOG_VERSION_NO 200707251 and function
quote_literal throws an error:

# select quote_literal(1);
2007-08-20 18:50:17 PDT ERROR: function quote_literal(integer) does not
exist at character 8
2007-08-20 18:50:17 PDT HINT: No function matches the given name and
argument types. You might need to add explicit type casts.
2007-08-20 18:50:17 PDT STATEMENT: select quote_literal(1);
ERROR: function quote_literal(integer) does not exist
LINE 1: select quote_literal(1);

I went back to an older snapshot CATALOG_VERSION_NO 200705211 and it
works with the same SunStudio compiler and options:

postgres=# select quote_literal(1);
quote_literal
---------------
'1'
(1 row)

-Jignesh


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Jignesh K(dot) Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Function quote_literal broken in CATALOG_VERSION_NO 200707251
Date: 2007-08-21 03:37:11
Message-ID: 20224.1187667431@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Jignesh K. Shah" <J(dot)K(dot)Shah(at)Sun(dot)COM> writes:
> # select quote_literal(1);
> 2007-08-20 18:50:17 PDT ERROR: function quote_literal(integer) does not
> exist at character 8

quote_literal(integer) never existed in any previous release, either.

What you are seeing is a side effect of the removal of implicit casts to
text. IMHO rejecting this query is a good thing.

regards, tom lane