Re: postgres messages error

Lists: pgsql-hackers
From: Martín Marqués <martin(at)2ndquadrant(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: postgres messages error
Date: 2014-12-17 12:58:24
Message-ID: 54917DF0.8090003@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi there,

I was doing some translation on postgres.po and found a string which
looks mistaken.

#: libpq/auth.c:1593
#, fuzzy, c-format
msgid "could not to look up local user ID %ld: %s"

It looks like there is an extra *to* there , so the string should be:

"could not look up local user ID %ld: %s"

Cheers,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

From: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>
To: Martín Marqués <martin(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres messages error
Date: 2014-12-17 17:07:00
Message-ID: CAKRt6CRmejHb9WhmPVysecYsMfp+KnNuZ-0N6dAAuQ4=FJfWVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Martin,

#: libpq/auth.c:1593
> #, fuzzy, c-format
> msgid "could not to look up local user ID %ld: %s"
>
> It looks like there is an extra *to* there , so the string should be:
>
> "could not look up local user ID %ld: %s"
>

I think you are right. FWIW, I have attached a patch that fixes it for
consideration if others concur.

-Adam

--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com

Attachment Content-Type Size
auth_c-error-message-fix.patch text/x-patch 643 bytes
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>
Cc: Martín Marqués <martin(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres messages error
Date: 2014-12-17 18:04:30
Message-ID: 4674.1418839470@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> writes:
> Martin,
> #: libpq/auth.c:1593
>> #, fuzzy, c-format
>> msgid "could not to look up local user ID %ld: %s"
>>
>> It looks like there is an extra *to* there , so the string should be:
>>
>> "could not look up local user ID %ld: %s"

> I think you are right. FWIW, I have attached a patch that fixes it for
> consideration if others concur.

I agree, that good English is not. Will commit.

regards, tom lane

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Martín Marqués <martin(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres messages error
Date: 2014-12-17 18:08:53
Message-ID: 20141217180853.GE1768@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Tom Lane wrote:
> Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com> writes:
> > Martin,
> > #: libpq/auth.c:1593
> >> #, fuzzy, c-format
> >> msgid "could not to look up local user ID %ld: %s"
> >>
> >> It looks like there is an extra *to* there , so the string should be:
> >>
> >> "could not look up local user ID %ld: %s"
>
> > I think you are right. FWIW, I have attached a patch that fixes it for
> > consideration if others concur.
>
> I agree, that good English is not. Will commit.

A quick grep reveals also

initdb.po:msgid "%s: could not to allocate SIDs: error code %lu\n"

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Martín Marqués <martin(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres messages error
Date: 2014-12-17 18:18:17
Message-ID: 9625.1418840297@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> A quick grep reveals also
> initdb.po:msgid "%s: could not to allocate SIDs: error code %lu\n"

Good catch, I'll get that one too.

regards, tom lane